Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h

Issue 1479113002: [Oilpan] Replace a raw pointer with UntracedMember in RetainedDOMInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 const char* GetGroupLabel() override; 50 const char* GetGroupLabel() override;
51 const char* GetLabel() override; 51 const char* GetLabel() override;
52 intptr_t GetElementCount() override; 52 intptr_t GetElementCount() override;
53 intptr_t GetEquivalenceClass() override; 53 intptr_t GetEquivalenceClass() override;
54 54
55 static v8::RetainedObjectInfo* retainedDOMInfo(uint16_t classId, v8::Local<v 8::Value> wrapper); 55 static v8::RetainedObjectInfo* retainedDOMInfo(uint16_t classId, v8::Local<v 8::Value> wrapper);
56 56
57 private: 57 private:
58 // V8 guarantees to keep RetainedObjectInfos alive only during a GC or heap snapshotting round, when renderer 58 // V8 guarantees to keep RetainedObjectInfos alive only during a GC or heap snapshotting round, when renderer
59 // doesn't get control. This allows us to use raw pointers. 59 // doesn't get control. This allows us to use raw pointers.
60 GC_PLUGIN_IGNORE("553613") 60 RawPtrWillBeUntracedMember<Node> m_root;
haraken 2015/11/27 05:11:11 Yes, this pointer is pretty special (as commented
61 Node* m_root;
62 }; 61 };
63 62
64 class ActiveDOMObjectsInfo final : public RetainedObjectInfo { 63 class ActiveDOMObjectsInfo final : public RetainedObjectInfo {
65 public: 64 public:
66 explicit ActiveDOMObjectsInfo(int numberOfObjectsWithPendingActivity); 65 explicit ActiveDOMObjectsInfo(int numberOfObjectsWithPendingActivity);
67 ~ActiveDOMObjectsInfo() override; 66 ~ActiveDOMObjectsInfo() override;
68 void Dispose() override; 67 void Dispose() override;
69 bool IsEquivalent(v8::RetainedObjectInfo* other) override; 68 bool IsEquivalent(v8::RetainedObjectInfo* other) override;
70 intptr_t GetHash() override; 69 intptr_t GetHash() override;
71 const char* GetGroupLabel() override; 70 const char* GetGroupLabel() override;
72 const char* GetLabel() override; 71 const char* GetLabel() override;
73 intptr_t GetElementCount() override; 72 intptr_t GetElementCount() override;
74 intptr_t GetEquivalenceClass() override; 73 intptr_t GetEquivalenceClass() override;
75 74
76 private: 75 private:
77 int m_numberOfObjectsWithPendingActivity; 76 int m_numberOfObjectsWithPendingActivity;
78 }; 77 };
79 78
80 } // namespace blink 79 } // namespace blink
81 80
82 #endif // RetainedDOMInfo_h 81 #endif // RetainedDOMInfo_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698