Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests (Closed)

Created:
6 years, 10 months ago by guohui

Modified:
6 years, 10 months ago

Reviewers:
kinuko, alecflett

CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, jsbell

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests (https://codereview.chromium.org/153553008/) Reason for revert: Suspect cause for failing content_browsertests:ServiceWorkerVersionBrowserTests Original issue's description: > Wire InstallFinished and add some InstallEvent.waitUntil tests > > BUG=285976 > TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Install* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250804 TBR=alecflett@chromium.org,kinuko@chromium.org NOTREECHECKS=true NOTRY=true BUG=285976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250886

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -65 lines)			Patch
M	content/browser/service_worker/service_worker_browsertest.cc	View	2 chunks	+22 lines, -38 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_context_client.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_context_client.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/renderer/service_worker/service_worker_script_context.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	content/test/data/service_worker/worker.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	content/test/data/service_worker/worker_install_fulfilled.js	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	content/test/data/service_worker/worker_install_rejected.js	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

guohui

Created Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests

6 years, 10 months ago (2014-02-13 01:17:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/147903008/1

6 years, 10 months ago (2014-02-13 01:19:52 UTC) #2

Message was sent while issue was closed.

Change committed as 250886