content/renderer/service_worker/service_worker_script_context.cc - Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_client.cc ('k') | content/test/data/service_worker/worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.cc

diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc

index 3edd887bac377321d48410a1d8ff15bd1f464713..2930ce22bd1733a3a91455cf5bf6a49c45e8b8f0 100644

--- a/content/renderer/service_worker/service_worker_script_context.cc

+++ b/content/renderer/service_worker/service_worker_script_context.cc

@@ -48,7 +48,12 @@

void ServiceWorkerScriptContext::OnInstallEvent(

int active_version_embedded_worker_id) {

- proxy_->dispatchInstallEvent(current_request_id_);

+ // TODO(kinuko): Uncomment this when blink side becomes ready.

+ // proxy_->dispatchInstallEvent(current_request_id_);

+ // TODO(kinuko): this should be called asynchronously from blink side

+ // when blink-side plumbing is done.

+ DidHandleInstallEvent(current_request_id_);

}

void ServiceWorkerScriptContext::OnFetchEvent(

« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_client.cc ('k') | content/test/data/service_worker/worker.js » ('j') | no next file with comments »