content/renderer/service_worker/embedded_worker_context_client.h - Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 147903008: Revert of Wire InstallFinished and add some InstallEvent.waitUntil tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/renderer/service_worker/embedded_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.h

diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h

index 7205e8d22fab38cbfd63459b178ec22c9aec47f4..65c0ea454c0978cdc9064938c8c608f45b1daacb 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.h

+++ b/content/renderer/service_worker/embedded_worker_context_client.h

@@ -49,12 +49,10 @@

void SendMessageToBrowser(int request_id, const IPC::Message& message);

- // WebServiceWorkerContextClient overrides, some of them are just dispatched

- // on to script_context_.

+ // WebServiceWorkerContextClient overrides.

virtual void workerContextFailedToStart();

virtual void workerContextStarted(blink::WebServiceWorkerContextProxy* proxy);

virtual void workerContextDestroyed();

- virtual void didHandleInstallEvent(int request_id);

// TODO: Implement DevTools related method overrides.