Issue 14789003: mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots.

Issue 14789003: mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots. (Closed)

Created:
7 years, 7 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots. BUG=170629 R=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201361

Patch Set 2 : comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	build/common.gypi	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/14789003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14789003/diff/1/build/common.gypi#newcode1541 build/common.gypi:1541: # runtime is fully adopted. See http://crbug.com/170629. Can this ...

7 years, 7 months ago (2013-05-01 19:13:46 UTC) #1

Alexander Potapenko

LGTM https://codereview.chromium.org/14789003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14789003/diff/1/build/common.gypi#newcode1541 build/common.gypi:1541: # runtime is fully adopted. See http://crbug.com/170629. On ...

7 years, 7 months ago (2013-05-21 13:21:50 UTC) #2

Nico

Thanks! https://codereview.chromium.org/14789003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14789003/diff/1/build/common.gypi#newcode1541 build/common.gypi:1541: # runtime is fully adopted. See http://crbug.com/170629. On ...

7 years, 7 months ago (2013-05-21 19:19:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14789003/6001

7 years, 7 months ago (2013-05-21 19:20:17 UTC) #4

Nico

7 years, 7 months ago (2013-05-21 21:28:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r201361 (presubmit successful).

Expand Messages | Collapse Messages