Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: build/common.gypi

Issue 14789003: mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a618576c16955b855ddd02748d28b5eda6ed5e2a..ad2f4c553e0fccfe3c4591db26ebf5573201d56e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1552,7 +1552,7 @@
# See http://crbug.com/145503.
'component': "static_library",
# TODO(glider): we do not strip ASan binaries until the dynamic ASan
- # runtime is fully adopted. See http://crbug.com/170629.
+ # runtime is fully adopted. See http://crbug.com/242503.
'mac_strip_release': 0,
}],
['tsan==1', {
@@ -3727,10 +3727,7 @@
'$(inherited)', '-std=gnu++11',
],
}],
- # TODO(thakis): Reenable plugins with once
- # tools/clang/scripts/update.sh no longer pins clang to an ancient
- # version for asan (http://crbug.com/170629)
- ['clang==1 and clang_use_chrome_plugins==1 and asan!=1', {
+ ['clang==1 and clang_use_chrome_plugins==1', {
'OTHER_CFLAGS': [
'<@(clang_chrome_plugins_flags)',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698