mac: Reenable clang plugin on asan bot now that it's using the same clang as the other bots.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 1520 matching lines @@
         ],
       }],
 
       ['asan==1 and OS!="win"', {
         'clang%': 1,
       }],
       ['asan==1 and OS=="mac"', {
         # See http://crbug.com/145503.
         'component': "static_library",
         # TODO(glider): we do not strip ASan binaries until the dynamic ASan
         # runtime is fully adopted. See http://crbug.com/170629.

[Nico, 2013/05/01 19:13:46]

Can this be removed, too?

[Alexander Potapenko, 2013/05/21 13:21:50]

I've checked that recently and there still were problems related to missing ASan
API symbols being stripped. Need to take another look.
Can you please change this to http://crbug.com/242503?

[Nico, 2013/05/21 19:19:55]

Done.

         'mac_strip_release': 0,
       }],
       ['tsan==1', {
         'clang%': 1,
       }],
       ['msan==1', {
         'clang%': 1,
       }],
 
       ['OS=="linux" and clang_type_profiler==1', {
@@ skipping 2161 matching lines @@
                 # typeof() is also disabled in c++11 (but we could use
                 # decltype() instead).
                 # TODO(thakis): Use CLANG_CXX_LANGUAGE_STANDARD instead once all
                 # bots use xcode 4 -- http://crbug.com/147515).
                 # TODO(thakis): Eventually switch this to c++11 instead of
                 # gnu++11 (once typeof can be removed, which is blocked on c++11
                 # being available everywhere).
                 '$(inherited)', '-std=gnu++11',
               ],
             }],
-            # TODO(thakis): Reenable plugins with once
-            # tools/clang/scripts/update.sh no longer pins clang to an ancient
-            # version for asan (http://crbug.com/170629)
-            ['clang==1 and clang_use_chrome_plugins==1 and asan!=1', {
+            ['clang==1 and clang_use_chrome_plugins==1', {
               'OTHER_CFLAGS': [
                 '<@(clang_chrome_plugins_flags)',
               ],
             }],
             ['clang==1 and clang_load!=""', {
               'OTHER_CFLAGS': [
                 '-Xclang', '-load', '-Xclang', '<(clang_load)',
               ],
             }],
             ['clang==1 and clang_add_plugin!=""', {
@@ skipping 663 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }