mb: add MB entries for CFI Linux buildbot and enable gn.

mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692, 561677
Committed: https://crrev.com/702144379eeca6e4d25a593be7677ab1eb3baf62
Cr-Commit-Position: refs/heads/master@{#362205}

[krasin, 2015-11-26 00:13:31]

krasin@google.com changed reviewers:
+ dpranke@google.com

[krasin, 2015-11-26 00:13:31]

Hi Dirk,

this is to convert build.chromium.org/p/chromium.fyi/builders/CFI Linux to GN. I
figured that I need to add an MB entry for that, but I could have missed
something.

We have two more buildbots, but I would like to enable just one buildbot for
now, as we'll need to plumb some additional stuff on GN side for them.

[krasin, 2015-11-26 00:15:17]

Description was changed from

==========
mb: add MB entried for CFI Linux buildbot and enable gn.

BUG=481692,561677
==========

to

==========
mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692,561677
==========

[Dirk Pranke, 2015-11-26 01:11:26]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-11-26 01:11:27]

lgtm w/ nit, below.

https://codereview.chromium.org/1478863004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1478863004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:42: 'gn_cfi_bot': ['gn', 'cfi', 'clang', 'release_bot'],
you don't need 'clang'; 'clang' is on by default, and I try to omit flags that
are not needed.

[Dirk Pranke, 2015-11-26 01:12:25]

actually, didn't you say that CFI Linux is only for 32-bit bots?

These flags'll produce a 64-bit build. Is that what you want?

[kcc2, 2015-11-26 01:14:17]

On 2015/11/26 01:12:25, Dirk Pranke wrote:
> actually, didn't you say that CFI Linux is only for 32-bit bots?
> 
> These flags'll produce a 64-bit build. Is that what you want?

Our primary target with CFI is 64-bit Linux at this point. 
32-bit would be nice to have too, but not urgent.

[krasin, 2015-11-30 18:28:35]

https://codereview.chromium.org/1478863004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1478863004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:42: 'gn_cfi_bot': ['gn', 'cfi', 'clang', 'release_bot'],
On 2015/11/26 01:11:26, Dirk Pranke wrote:
> you don't need 'clang'; 'clang' is on by default, and I try to omit flags that
> are not needed.

Done.

[krasin, 2015-11-30 18:29:05]

On 2015/11/26 01:12:25, Dirk Pranke wrote:
> actually, didn't you say that CFI Linux is only for 32-bit bots?
> 
> These flags'll produce a 64-bit build. Is that what you want?

As kcc said, we're for 64-bit only. Thanks for confirming that this CL will work
for us. :)

[krasin, 2015-11-30 18:29:08]

The CQ bit was checked by krasin@google.com

[krasin, 2015-11-30 18:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1478863004/#ps20001
(title: "remove clang (it's default)")

[commit-bot: I haz the power, 2015-11-30 18:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478863004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478863004/20001

[commit-bot: I haz the power, 2015-11-30 20:12:46]

Description was changed from

==========
mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692,561677
==========

to

==========
mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692,561677
==========

[commit-bot: I haz the power, 2015-11-30 20:12:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-30 20:13:42]

Description was changed from

==========
mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692,561677
==========

to

==========
mb: add MB entries for CFI Linux buildbot and enable gn.

BUG=481692,561677

Committed: https://crrev.com/702144379eeca6e4d25a593be7677ab1eb3baf62
Cr-Commit-Position: refs/heads/master@{#362205}
==========

[commit-bot: I haz the power, 2015-11-30 20:13:42]

Patchset 2 (id:??) landed as
https://crrev.com/702144379eeca6e4d25a593be7677ab1eb3baf62
Cr-Commit-Position: refs/heads/master@{#362205}

[krasin, 2015-12-01 00:06:53]

Dirk, does this require a master restart to take an effect?

The buildbot seems to be still GYP-based:
http://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3583

[Dirk Pranke, 2015-12-01 00:13:26]

On 2015/12/01 00:06:53, krasin wrote:
> Dirk, does this require a master restart to take an effect?
> 

This change does not, but

> The buildbot seems to be still GYP-based:
> http://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3583

You need to make a buildbot-side change to tell the recipe to use MB instead
of using GYP as part of runhooks.

Add a line that says:

  'chromium_apply_config': ['mb']

to 

https://code.google.com/p/chromium/codesearch?q=chromium_fyi.py#chromium/buil...

That change will not require a master restart, either.

[krasin, 2015-12-01 00:50:54]

Thank you, Dirk, for the pointers! The CL is out:
https://codereview.chromium.org/1486883002

[Dirk Pranke, 2015-12-01 00:56:40]

On 2015/12/01 00:50:54, krasin wrote:
> Thank you, Dirk, for the pointers! The CL is out:
> https://codereview.chromium.org/1486883002

As I just replied in the build-side CL, I didn't realize you also had a matching
trybot :(. You'll need to add that one as well to this file.

Sorry!