Convert CFI Linux buildbot to MB (recipes part)

Convert CFI Linux buildbot to MB (recipes part)

BUG=481692, 561677
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297748

[krasin, 2015-12-01 00:50:28]

krasin@google.com changed reviewers:
+ dpranke@google.com

[Dirk Pranke, 2015-12-01 00:55:54]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-12-01 00:55:54]

lgtm, but I didn't realize you also had a matching trybot :(

So, you need to make another change to the src-side tools/mb/mb_config.pyl to
add an entry for linux_chromium_cfi_rel_ng as well. "matching" often doesn't
actually mean matching as far as MB is concerned (the trybots can have different
flags from the waterfall bots) so you have to have both sets of entries.

[krasin, 2015-12-01 00:58:22]

On 2015/12/01 00:55:54, Dirk Pranke wrote:
> lgtm, but I didn't realize you also had a matching trybot :(
> 
> So, you need to make another change to the src-side tools/mb/mb_config.pyl to
> add an entry for linux_chromium_cfi_rel_ng as well. "matching" often doesn't
> actually mean matching as far as MB is concerned (the trybots can have
different
> flags from the waterfall bots) so you have to have both sets of entries.

I actually plan to pass on trybot for now. It's not blocking the launch, and we
very rarely use it.

Later, I will convert trybots and two other our buildbots (CFI Linux ToT and CFI
Linux CF).

Does it sound ok to you?

[krasin, 2015-12-01 01:00:57]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2015-12-01 01:01:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486883002/1

[Dirk Pranke, 2015-12-01 01:01:20]

On 2015/12/01 00:58:22, krasin wrote:
> On 2015/12/01 00:55:54, Dirk Pranke wrote:
> > lgtm, but I didn't realize you also had a matching trybot :(
> > 
> > So, you need to make another change to the src-side tools/mb/mb_config.pyl
to
> > add an entry for linux_chromium_cfi_rel_ng as well. "matching" often doesn't
> > actually mean matching as far as MB is concerned (the trybots can have
> different
> > flags from the waterfall bots) so you have to have both sets of entries.
> 
> I actually plan to pass on trybot for now. It's not blocking the launch, and
we
> very rarely use it.
> 
> Later, I will convert trybots and two other our buildbots (CFI Linux ToT and
CFI
> Linux CF).
>

So, the trybot will pick up the change to use MB from this CL, but when it tries
to
run MB, it won't find a matching entry for the bot, and the build will fail. As
long
as you don't care about the trybot being completely broken for now
you can do whatever you like :).

-- Dirk

[krasin, 2015-12-01 01:03:27]

On 2015/12/01 01:01:20, Dirk Pranke wrote:
> On 2015/12/01 00:58:22, krasin wrote:
> > On 2015/12/01 00:55:54, Dirk Pranke wrote:
> > > lgtm, but I didn't realize you also had a matching trybot :(
> > > 
> > > So, you need to make another change to the src-side tools/mb/mb_config.pyl
> to
> > > add an entry for linux_chromium_cfi_rel_ng as well. "matching" often
doesn't
> > > actually mean matching as far as MB is concerned (the trybots can have
> > different
> > > flags from the waterfall bots) so you have to have both sets of entries.
> > 
> > I actually plan to pass on trybot for now. It's not blocking the launch, and
> we
> > very rarely use it.
> > 
> > Later, I will convert trybots and two other our buildbots (CFI Linux ToT and
> CFI
> > Linux CF).
> >
> 
> So, the trybot will pick up the change to use MB from this CL, but when it
tries
> to
> run MB, it won't find a matching entry for the bot, and the build will fail.
As
> long
> as you don't care about the trybot being completely broken for now
> you can do whatever you like :).
> 
> -- Dirk

Yes, I don't care about the trybot for now. Having it broken for a few days
seems just fine to me.

Thank you very much for your help.

One question for the future: how do I update expectations without manual
changes? Right now I resort to running
scripts/slave/unittests/recipe_simulation_test.py and fixing the expectations in
my editor.

[commit-bot: I haz the power, 2015-12-01 01:03:47]

Description was changed from

==========
Convert CFI Linux buildbot to MB (recipes part)

BUG=481692, 561677
==========

to

==========
Convert CFI Linux buildbot to MB (recipes part)

BUG=481692, 561677

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297748
==========

[commit-bot: I haz the power, 2015-12-01 01:03:48]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297748

[Dirk Pranke, 2015-12-01 01:05:04]

On 2015/12/01 01:03:27, krasin wrote:
> One question for the future: how do I update expectations without manual
> changes? Right now I resort to running
> scripts/slave/unittests/recipe_simulation_test.py and fixing the expectations
in
> my editor.

Run

    scripts/slave/unittests/recipe_simulation_test.py train

and that will update the files for you.

[krasin, 2015-12-01 01:06:07]

On 2015/12/01 01:05:04, Dirk Pranke wrote:
> On 2015/12/01 01:03:27, krasin wrote:
> > One question for the future: how do I update expectations without manual
> > changes? Right now I resort to running
> > scripts/slave/unittests/recipe_simulation_test.py and fixing the
expectations
> in
> > my editor.
> 
> Run
> 
>     scripts/slave/unittests/recipe_simulation_test.py train
> 
> and that will update the files for you.

Thank you. The answer allowed me to find the doc:
https://github.com/luci/recipes-py/blob/master/doc/user_guide.md
I failed to do that.

[Dirk Pranke, 2015-12-01 01:21:18]

On 2015/12/01 01:06:07, krasin wrote:
> Thank you. The answer allowed me to find the doc:
> https://github.com/luci/recipes-py/blob/master/doc/user_guide.md
> I failed to do that.

Our documentation is sadly not as well indexed/crawled on the google as we would
like yet :).