gpu: Initial implementation of CommitOverlayPlanes

gpu: Initial implementation of CommitOverlayPlanes

* Add ContextSupport::CommitOverlayPlanes to mirror Swap and
  PartialSwapBuffers.
* Implement GLES2Implementation::CommitOverlayPlanes(CHROMIUM) similarly
  to SwapBuffers.
* Add to GLSurface: SupportsCommitOverlayPlanes, CommitOverlayPlanes, and
  CommitOverlayPlanesAsync for symmetry with SwapBuffers.
* Implement PassThroughImageTransportSurface::CommitOverlayPlanes to
  collect latency info like it does for SwapBuffers.

BUG=560592
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cdb42a6a0a4ad22ab61ae0c4054fcba1568a5b4a
Cr-Commit-Position: refs/heads/master@{#362314}

[watk, 2015-11-25 01:33:45]

watk@chromium.org changed reviewers:
+ ccameron@chromium.org, piman@chromium.org

[watk, 2015-11-25 01:33:45]

watk@chromium.org changed required reviewers:
+ piman@chromium.org

[watk, 2015-11-25 01:33:45]

Hey piman, ccameron: here's the next step for plumbing CommitOverlayPlanes
through. After this I'll have another one to change GLRenderer and
DirectRenderer to know about COP.

[piman, 2015-11-25 06:49:28]

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
ui/gl/gl_surface_egl.cc:735: return true;
This is not right for GLSurfaceOzoneEGL, which inherits from
NativeViewGLSurfaceEGL.
Did you mean this only for Android?

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
ui/gl/gl_surface_egl.cc:739: return gfx::SwapResult::SWAP_ACK;
It feels like the planes should be scheduled only at this point - i.e.
ScheduleOverlayPlanes would keep pending changes in a list, and only here commit
the list. Even if not atomic, at least it would follow the same scheduling logic
as the rest.

[watk, 2015-11-25 21:10:13]

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
ui/gl/gl_surface_egl.cc:735: return true;
On 2015/11/25 06:49:28, piman (slow to review) wrote:
> This is not right for GLSurfaceOzoneEGL, which inherits from
> NativeViewGLSurfaceEGL.
> Did you mean this only for Android?

Oops, I didn't really mean to include this change. I removed it to keep this
change focused on the plumbing. I'll do the Android specific stuff in a follow
up.

https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
ui/gl/gl_surface_egl.cc:739: return gfx::SwapResult::SWAP_ACK;
On 2015/11/25 06:49:28, piman (slow to review) wrote:
> It feels like the planes should be scheduled only at this point - i.e.
> ScheduleOverlayPlanes would keep pending changes in a list, and only here
commit
> the list. Even if not atomic, at least it would follow the same scheduling
logic
> as the rest.

Yeah, I can do that (removed for this CL). I think I'll pull
GLSurfaceOzoneSurfaceless::Overlay into a new file like
ui/gl/gl_surface_overlay.h and basically do what GLSurfaceOzoneSurfaceless where
it keeps a vector of overlays. It also looks like it's getting time to subclass
GLSurfaceEGL for android at that point?

[watk, 2015-11-25 21:11:26]

watk@chromium.org changed reviewers:
+ nasko@chromium.org

[watk, 2015-11-25 21:11:26]

nasko@chromium.org: Please review changes in gpu/ipc

[piman, 2015-11-25 23:29:28]

lgtm

[piman, 2015-11-25 23:30:13]

On Wed, Nov 25, 2015 at 1:10 PM, <watk@chromium.org> wrote:

>
>
> https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc
> File ui/gl/gl_surface_egl.cc (right):
>
>
>
https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
> ui/gl/gl_surface_egl.cc:735: return true;
> On 2015/11/25 06:49:28, piman (slow to review) wrote:
>
>> This is not right for GLSurfaceOzoneEGL, which inherits from
>> NativeViewGLSurfaceEGL.
>> Did you mean this only for Android?
>>
>
> Oops, I didn't really mean to include this change. I removed it to keep
> this change focused on the plumbing. I'll do the Android specific stuff
> in a follow up.
>
>
>
https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
> ui/gl/gl_surface_egl.cc:739: return gfx::SwapResult::SWAP_ACK;
> On 2015/11/25 06:49:28, piman (slow to review) wrote:
>
>> It feels like the planes should be scheduled only at this point - i.e.
>> ScheduleOverlayPlanes would keep pending changes in a list, and only
>>
> here commit
>
>> the list. Even if not atomic, at least it would follow the same
>>
> scheduling logic
>
>> as the rest.
>>
>
> Yeah, I can do that (removed for this CL). I think I'll pull
> GLSurfaceOzoneSurfaceless::Overlay into a new file like
> ui/gl/gl_surface_overlay.h and basically do what
> GLSurfaceOzoneSurfaceless where it keeps a vector of overlays. It also
> looks like it's getting time to subclass GLSurfaceEGL for android at
> that point?
>

Probably, yes. I think we went back and forth


>
> https://codereview.chromium.org/1477593002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[watk, 2015-11-30 19:46:40]

On 2015/11/25 23:30:13, piman (slow to review) wrote:
> On Wed, Nov 25, 2015 at 1:10 PM, <mailto:watk@chromium.org> wrote:
> 
> >
> >
> >
https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc
> > File ui/gl/gl_surface_egl.cc (right):
> >
> >
> >
>
https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
> > ui/gl/gl_surface_egl.cc:735: return true;
> > On 2015/11/25 06:49:28, piman (slow to review) wrote:
> >
> >> This is not right for GLSurfaceOzoneEGL, which inherits from
> >> NativeViewGLSurfaceEGL.
> >> Did you mean this only for Android?
> >>
> >
> > Oops, I didn't really mean to include this change. I removed it to keep
> > this change focused on the plumbing. I'll do the Android specific stuff
> > in a follow up.
> >
> >
> >
>
https://codereview.chromium.org/1477593002/diff/20001/ui/gl/gl_surface_egl.cc...
> > ui/gl/gl_surface_egl.cc:739: return gfx::SwapResult::SWAP_ACK;
> > On 2015/11/25 06:49:28, piman (slow to review) wrote:
> >
> >> It feels like the planes should be scheduled only at this point - i.e.
> >> ScheduleOverlayPlanes would keep pending changes in a list, and only
> >>
> > here commit
> >
> >> the list. Even if not atomic, at least it would follow the same
> >>
> > scheduling logic
> >
> >> as the rest.
> >>
> >
> > Yeah, I can do that (removed for this CL). I think I'll pull
> > GLSurfaceOzoneSurfaceless::Overlay into a new file like
> > ui/gl/gl_surface_overlay.h and basically do what
> > GLSurfaceOzoneSurfaceless where it keeps a vector of overlays. It also
> > looks like it's getting time to subclass GLSurfaceEGL for android at
> > that point?
> >
> 
> Probably, yes. I think we went back and forth
> 
> 
> >
> > https://codereview.chromium.org/1477593002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

nasko@: friendly ping

[nasko, 2015-11-30 23:54:47]

LGTM

[watk, 2015-11-30 23:57:06]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2015-11-30 23:57:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477593002/60001

[commit-bot: I haz the power, 2015-12-01 01:55:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-01 01:55:57]

Description was changed from

==========
gpu: Initial implementation of CommitOverlayPlanes

* Add ContextSupport::CommitOverlayPlanes to mirror Swap and
  PartialSwapBuffers.
* Implement GLES2Implementation::CommitOverlayPlanes(CHROMIUM) similarly
  to SwapBuffers.
* Add to GLSurface: SupportsCommitOverlayPlanes, CommitOverlayPlanes, and
  CommitOverlayPlanesAsync for symmetry with SwapBuffers.
* Implement PassThroughImageTransportSurface::CommitOverlayPlanes to
  collect latency info like it does for SwapBuffers.

BUG=560592
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
gpu: Initial implementation of CommitOverlayPlanes

* Add ContextSupport::CommitOverlayPlanes to mirror Swap and
  PartialSwapBuffers.
* Implement GLES2Implementation::CommitOverlayPlanes(CHROMIUM) similarly
  to SwapBuffers.
* Add to GLSurface: SupportsCommitOverlayPlanes, CommitOverlayPlanes, and
  CommitOverlayPlanesAsync for symmetry with SwapBuffers.
* Implement PassThroughImageTransportSurface::CommitOverlayPlanes to
  collect latency info like it does for SwapBuffers.

BUG=560592
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cdb42a6a0a4ad22ab61ae0c4054fcba1568a5b4a
Cr-Commit-Position: refs/heads/master@{#362314}
==========

[commit-bot: I haz the power, 2015-12-01 01:55:59]

Patchset 4 (id:??) landed as
https://crrev.com/cdb42a6a0a4ad22ab61ae0c4054fcba1568a5b4a
Cr-Commit-Position: refs/heads/master@{#362314}