gpu: Initial implementation of CommitOverlayPlanes

ui/gl/gl_surface_egl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface_egl.h"
 
 #if defined(OS_ANDROID)
 #include <android/native_window_jni.h>
 #endif
 
@@ skipping 713 matching lines @@
                                                       int height) {
   DCHECK(supports_post_sub_buffer_);
   if (!eglPostSubBufferNV(GetDisplay(), surface_, x, y, width, height)) {
     DVLOG(1) << "eglPostSubBufferNV failed with error "
              << GetLastEGLErrorString();
     return gfx::SwapResult::SWAP_FAILED;
   }
   return gfx::SwapResult::SWAP_ACK;
 }
 
+bool NativeViewGLSurfaceEGL::SupportsCommitOverlayPlanes() {
+  return true;

[piman, 2015/11/25 06:49:28]

This is not right for GLSurfaceOzoneEGL, which inherits from
NativeViewGLSurfaceEGL.
Did you mean this only for Android?

[watk, 2015/11/25 21:10:13]

Oops, I didn't really mean to include this change. I removed it to keep this
change focused on the plumbing. I'll do the Android specific stuff in a follow
up. 

+}
+
+gfx::SwapResult NativeViewGLSurfaceEGL::CommitOverlayPlanes() {
+  return gfx::SwapResult::SWAP_ACK;

[piman, 2015/11/25 06:49:28]

It feels like the planes should be scheduled only at this point - i.e.
ScheduleOverlayPlanes would keep pending changes in a list, and only here commit
the list. Even if not atomic, at least it would follow the same scheduling logic
as the rest.

[watk, 2015/11/25 21:10:13]

Yeah, I can do that (removed for this CL). I think I'll pull
GLSurfaceOzoneSurfaceless::Overlay into a new file like
ui/gl/gl_surface_overlay.h and basically do what GLSurfaceOzoneSurfaceless where
it keeps a vector of overlays. It also looks like it's getting time to subclass
GLSurfaceEGL for android at that point?

+}
+
 VSyncProvider* NativeViewGLSurfaceEGL::GetVSyncProvider() {
   return vsync_provider_.get();
 }
 
 void NativeViewGLSurfaceEGL::OnSetSwapInterval(int interval) {
   swap_interval_ = interval;
 }
 
 NativeViewGLSurfaceEGL::~NativeViewGLSurfaceEGL() {
   Destroy();
@@ skipping 170 matching lines @@
 }
 
 void* SurfacelessEGL::GetShareHandle() {
   return NULL;
 }
 
 SurfacelessEGL::~SurfacelessEGL() {
 }
 
 }  // namespace gfx