Add CommitOverlayPlanesCHROMIUM command buffer function

Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
Committed: https://crrev.com/f3c6a7898179b250386d04d621a30bc239ae9af8
Cr-Commit-Position: refs/heads/master@{#362253}

[watk, 2015-11-24 01:41:43]

watk@chromium.org changed reviewers:
+ piman@chromium.org

[watk, 2015-11-24 01:42:20]

Description was changed from

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
==========

to

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
==========

[piman, 2015-11-24 01:56:56]

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:4176: 'type': 'Custom',
Meh, just leave it as a regular function and get the validation for free!
See SwapBuffers.

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:4177: 'impl_func': False,
Why not True?

[watk, 2015-11-24 21:13:42]

Thanks, PTAL

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:4176: 'type': 'Custom',
On 2015/11/24 01:56:56, piman (slow to review) wrote:
> Meh, just leave it as a regular function and get the validation for free!
> See SwapBuffers.

Sounds good.

https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:4177: 'impl_func': False,
On 2015/11/24 01:56:56, piman (slow to review) wrote:
> Why not True?

I did it like this to mirror SwapBuffers so it's possible to do the same stuff
where it inserts a token, Swaps, Flushes, and waits on the token. I was assuming
CommitOverlayPlanes should do the same thing. (But I don't fully understand why
that's required so.. I'm probably wrong.)

[watk, 2015-11-24 21:14:07]

On 2015/11/24 21:13:42, watk wrote:
> Thanks, PTAL
> 
>
https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
> File gpu/command_buffer/build_gles2_cmd_buffer.py (right):
> 
>
https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
> gpu/command_buffer/build_gles2_cmd_buffer.py:4176: 'type': 'Custom',
> On 2015/11/24 01:56:56, piman (slow to review) wrote:
> > Meh, just leave it as a regular function and get the validation for free!
> > See SwapBuffers.
> 
> Sounds good.

I should have said this is done in PS2.

> 
>
https://codereview.chromium.org/1472993003/diff/1/gpu/command_buffer/build_gl...
> gpu/command_buffer/build_gles2_cmd_buffer.py:4177: 'impl_func': False,
> On 2015/11/24 01:56:56, piman (slow to review) wrote:
> > Why not True?
> 
> I did it like this to mirror SwapBuffers so it's possible to do the same stuff
> where it inserts a token, Swaps, Flushes, and waits on the token. I was
assuming
> CommitOverlayPlanes should do the same thing. (But I don't fully understand
why
> that's required so.. I'm probably wrong.)

[piman, 2015-11-24 21:29:05]

LGTM. Ok, we should parallel SwapBuffers for the client side.

[watk, 2015-11-24 21:38:21]

watk@chromium.org changed reviewers:
+ yzshen@chromium.org

[watk, 2015-11-24 21:38:21]

yzshen@chromium.org: Please review
mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h

[ccameron, 2015-11-24 22:45:10]

ccameron@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2015-11-24 22:45:11]

lgtm too -- I'll update Mac to use this as well (we can elide some work if we
know we're not waiting for GL).

[watk, 2015-11-24 23:45:03]

Thanks, I forgot to add CHROMIUM_commit_overlay_planes.txt. Added in PS3.

[piman, 2015-11-25 06:36:40]

lgtm

[watk, 2015-11-30 19:47:40]

yzshen1@: friendly ping

[yzshen1, 2015-11-30 20:55:54]

On 2015/11/30 19:47:40, watk wrote:
> yzshen1@: friendly ping

LGTM for gles2_call_visitor_chromium_extension_autogen.h

Sorry for the delay. Please feel free to IM me next time if you think I may have
missed the CL.

[watk, 2015-11-30 21:00:28]

The CQ bit was checked by watk@chromium.org

[watk, 2015-11-30 21:00:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/1472993003/#ps40001
(title: "Forgot to add the extension description txt file")

[commit-bot: I haz the power, 2015-11-30 21:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472993003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472993003/40001

[commit-bot: I haz the power, 2015-11-30 22:45:58]

Description was changed from

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
==========

to

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
==========

[commit-bot: I haz the power, 2015-11-30 22:45:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-30 22:46:38]

Description was changed from

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592
==========

to

==========
Add CommitOverlayPlanesCHROMIUM command buffer function

This extension is for displaying overlay planes without swapping the
framebuffer. This is useful when overlays account for all the damage and
it would be more efficient to not swap.

This patch is the result of adding the command to
cmd_buffer_functions.txt and build_gles2_cmd_buffer.py and running the
latter. The implementations will be added in a following CL.

BUG=560592

Committed: https://crrev.com/f3c6a7898179b250386d04d621a30bc239ae9af8
Cr-Commit-Position: refs/heads/master@{#362253}
==========

[commit-bot: I haz the power, 2015-11-30 22:46:40]

Patchset 3 (id:??) landed as
https://crrev.com/f3c6a7898179b250386d04d621a30bc239ae9af8
Cr-Commit-Position: refs/heads/master@{#362253}