Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1477343002: Pass an isolate to RelocInfo (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass an isolate to RelocInfo It needs ot to flush icaches all over the place BUG=v8:2487 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/508f122dec35ad44324cacad30ed3d1a54e6dedc Cr-Commit-Position: refs/heads/master@{#32371}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -59 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/assembler.h View 3 chunks +8 lines, -3 lines 0 comments Download
M src/assembler.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/liveedit.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/x87/assembler-x87.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/test-reloc-info.cc View 1 2 3 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
ptal
5 years ago (2015-11-27 10:59:51 UTC) #1
Yang
lgtm
5 years ago (2015-11-27 11:50:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477343002/60001
5 years ago (2015-11-27 11:52:40 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-27 12:18:42 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-27 12:19:32 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/508f122dec35ad44324cacad30ed3d1a54e6dedc
Cr-Commit-Position: refs/heads/master@{#32371}

Powered by Google App Engine
This is Rietveld 408576698