Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: test/cctest/test-reloc-info.cc

Issue 1477343002: Pass an isolate to RelocInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x87/deoptimizer-x87.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-reloc-info.cc
diff --git a/test/cctest/test-reloc-info.cc b/test/cctest/test-reloc-info.cc
index d2a780ba62384981e6c998c9b1647655dbc8e553..62437143b8e82bb07f2687fd4522a1724b852efe 100644
--- a/test/cctest/test-reloc-info.cc
+++ b/test/cctest/test-reloc-info.cc
@@ -29,6 +29,7 @@
#define V8_IMMINENT_DEPRECATION_WARNINGS
#include "src/assembler.h"
+#include "src/macro-assembler.h"
#include "test/cctest/cctest.h"
namespace v8 {
@@ -36,7 +37,7 @@ namespace internal {
static void WriteRinfo(RelocInfoWriter* writer,
byte* pc, RelocInfo::Mode mode, intptr_t data) {
- RelocInfo rinfo(pc, mode, data, NULL);
+ RelocInfo rinfo(CcTest::i_isolate(), pc, mode, data, NULL);
writer->Write(&rinfo);
}
@@ -44,6 +45,7 @@ static void WriteRinfo(RelocInfoWriter* writer,
// Tests that writing both types of positions and then reading either
// or both works as expected.
TEST(Positions) {
+ CcTest::InitializeVM();
const int code_size = 10 * KB;
int relocation_info_size = 10 * KB;
const int buffer_size = code_size + relocation_info_size;
@@ -68,8 +70,9 @@ TEST(Positions) {
writer.Finish();
relocation_info_size = static_cast<int>(buffer_end - writer.pos());
- CodeDesc desc = {buffer.get(), buffer_size, code_size, relocation_info_size,
- 0, NULL};
+ MacroAssembler assm(CcTest::i_isolate(), nullptr, 0, CodeObjectRequired::kNo);
+ CodeDesc desc = {buffer.get(), buffer_size, code_size,
+ relocation_info_size, 0, &assm};
// Read only (non-statement) positions.
{
« no previous file with comments | « src/x87/deoptimizer-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698