Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 1477343002: Pass an isolate to RelocInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/assembler-x87.cc ('k') | src/x87/deoptimizer-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 return Memory::Object_Handle_at(pc_); 127 return Memory::Object_Handle_at(pc_);
128 } 128 }
129 129
130 130
131 void RelocInfo::set_target_object(Object* target, 131 void RelocInfo::set_target_object(Object* target,
132 WriteBarrierMode write_barrier_mode, 132 WriteBarrierMode write_barrier_mode,
133 ICacheFlushMode icache_flush_mode) { 133 ICacheFlushMode icache_flush_mode) {
134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
135 Memory::Object_at(pc_) = target; 135 Memory::Object_at(pc_) = target;
136 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 136 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
137 Assembler::FlushICacheWithoutIsolate(pc_, sizeof(Address)); 137 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
138 } 138 }
139 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 139 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
140 host() != NULL && 140 host() != NULL &&
141 target->IsHeapObject()) { 141 target->IsHeapObject()) {
142 host()->GetHeap()->incremental_marking()->RecordWrite( 142 host()->GetHeap()->incremental_marking()->RecordWrite(
143 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 143 host(), &Memory::Object_at(pc_), HeapObject::cast(target));
144 } 144 }
145 } 145 }
146 146
147 147
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 193
194 194
195 void RelocInfo::set_target_cell(Cell* cell, 195 void RelocInfo::set_target_cell(Cell* cell,
196 WriteBarrierMode write_barrier_mode, 196 WriteBarrierMode write_barrier_mode,
197 ICacheFlushMode icache_flush_mode) { 197 ICacheFlushMode icache_flush_mode) {
198 DCHECK(cell->IsCell()); 198 DCHECK(cell->IsCell());
199 DCHECK(rmode_ == RelocInfo::CELL); 199 DCHECK(rmode_ == RelocInfo::CELL);
200 Address address = cell->address() + Cell::kValueOffset; 200 Address address = cell->address() + Cell::kValueOffset;
201 Memory::Address_at(pc_) = address; 201 Memory::Address_at(pc_) = address;
202 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 202 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
203 Assembler::FlushICacheWithoutIsolate(pc_, sizeof(Address)); 203 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
204 } 204 }
205 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) { 205 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) {
206 // TODO(1550) We are passing NULL as a slot because cell can never be on 206 // TODO(1550) We are passing NULL as a slot because cell can never be on
207 // evacuation candidate. 207 // evacuation candidate.
208 host()->GetHeap()->incremental_marking()->RecordWrite( 208 host()->GetHeap()->incremental_marking()->RecordWrite(
209 host(), NULL, cell); 209 host(), NULL, cell);
210 } 210 }
211 } 211 }
212 212
213 213
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 551
552 Operand::Operand(Immediate imm) { 552 Operand::Operand(Immediate imm) {
553 // [disp/r] 553 // [disp/r]
554 set_modrm(0, ebp); 554 set_modrm(0, ebp);
555 set_dispr(imm.x_, imm.rmode_); 555 set_dispr(imm.x_, imm.rmode_);
556 } 556 }
557 } // namespace internal 557 } // namespace internal
558 } // namespace v8 558 } // namespace v8
559 559
560 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 560 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x87/assembler-x87.cc ('k') | src/x87/deoptimizer-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698