Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1477043002: Fix tests that don't catch asynchronous errors from isolate spawning. Update co19 status. (Closed)

Created:
5 years ago by Alan Knight
Modified:
5 years ago
Reviewers:
terry, siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix tests that don't catch asynchronous errors from isolate spawning. Update co19 status. BUG= Committed: https://github.com/dart-lang/sdk/commit/c480c7beecc5082f154bee2e006d65c6a28e0262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -73 lines) Patch
M tests/co19/co19-dartium.status View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/isolate/issue_21398_parent_isolate1_test.dart View 6 chunks +48 lines, -32 lines 0 comments Download
M tests/isolate/issue_21398_parent_isolate2_test.dart View 3 chunks +4 lines, -0 lines 0 comments Download
M tests/isolate/issue_21398_parent_isolate_test.dart View 5 chunks +8 lines, -1 line 0 comments Download
M tests/isolate/message_enum_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/language/issue23244_test.dart View 4 chunks +3 lines, -1 line 0 comments Download
M tests/standalone/typed_array_int64_uint64_test.dart View 3 chunks +18 lines, -7 lines 0 comments Download
M tests/standalone/typed_array_test.dart View 9 chunks +46 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Alan Knight
TBR
5 years ago (2015-11-25 22:33:02 UTC) #2
Alan Knight
5 years ago (2015-11-25 22:33:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c480c7beecc5082f154bee2e006d65c6a28e0262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698