Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: tests/language/issue23244_test.dart

Issue 1477043002: Fix tests that don't catch asynchronous errors from isolate spawning. Update co19 status. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/message_enum_test.dart ('k') | tests/standalone/typed_array_int64_uint64_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/issue23244_test.dart
diff --git a/tests/language/issue23244_test.dart b/tests/language/issue23244_test.dart
index b15576995c17c5b26fa80fa98ba1e59fcdef9f83..f8a3f325961acbd653ee9139d1f850c261589f50 100644
--- a/tests/language/issue23244_test.dart
+++ b/tests/language/issue23244_test.dart
@@ -5,6 +5,7 @@
// Regression test case for http://dartbug.com/23244
import 'dart:async';
import 'dart:isolate';
+import 'package:async_helper/async_helper.dart';
enum Fisk {
torsk,
@@ -27,6 +28,7 @@ isolate3(SendPort port) {
main() async {
var port = new ReceivePort();
+ asyncStart();
await Isolate.spawn(isolate1, port.sendPort);
Completer completer1 = new Completer();
port.listen((message) {
@@ -53,6 +55,7 @@ main() async {
port.close();
expectTorsk(message[0]);
expectTorsk(message[1]);
+ asyncEnd();
});
}
@@ -61,4 +64,3 @@ expectTorsk(Fisk fisk) {
throw "$fisk isn't a ${Fisk.torsk}";
}
}
-
« no previous file with comments | « tests/isolate/message_enum_test.dart ('k') | tests/standalone/typed_array_int64_uint64_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698