Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: tests/isolate/message_enum_test.dart

Issue 1477043002: Fix tests that don't catch asynchronous errors from isolate spawning. Update co19 status. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/issue_21398_parent_isolate_test.dart ('k') | tests/language/issue23244_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate/message_enum_test.dart
diff --git a/tests/isolate/message_enum_test.dart b/tests/isolate/message_enum_test.dart
index 7dbaec3bb9964017296209cc9450a847925c601a..b06dfc34259d118494597a24f537c1416e3f9866 100644
--- a/tests/isolate/message_enum_test.dart
+++ b/tests/isolate/message_enum_test.dart
@@ -5,6 +5,7 @@
// SharedOptions=--enable-enum
import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import "dart:isolate";
enum Foo { BAR, BAZ }
@@ -18,7 +19,8 @@ main() {
Expect.equals(42, map[key]);
p.close();
});
- Isolate.spawn(sendIt, p.sendPort);
+ asyncStart();
+ Isolate.spawn(sendIt, p.sendPort).whenComplete(asyncEnd);
}
void sendIt(port) {
« no previous file with comments | « tests/isolate/issue_21398_parent_isolate_test.dart ('k') | tests/language/issue23244_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698