Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468933004: Allow in-object properties in JSCollections, JSWeakCollections and JSRegExp. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow in-object properties in JSCollections, JSWeakCollections and JSRegExp. BUG=v8:4531 LOG=Y Committed: https://crrev.com/2af5e36547e25858982a16e5a7c407745aea5f76 Cr-Commit-Position: refs/heads/master@{#32281}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M src/heap/objects-visiting.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 3 chunks +5 lines, -11 lines 0 comments Download
M src/objects.h View 1 chunk +13 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +22 lines, -16 lines 0 comments Download

Dependent Patchsets:

Issue 1476753003 Patch 1

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468933004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468933004/50001
5 years ago (2015-11-25 11:55:21 UTC) #5
Igor Sheludko
PTAL, nothing was done in this CL about static visiting of JSRegExp because the visitors ...
5 years ago (2015-11-25 11:56:33 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468933004/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468933004/70001
5 years ago (2015-11-25 13:47:10 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 14:12:57 UTC) #11
ulan
lgtm
5 years ago (2015-11-25 15:02:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468933004/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468933004/70001
5 years ago (2015-11-25 15:07:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:70001)
5 years ago (2015-11-25 15:22:28 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-25 15:23:09 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2af5e36547e25858982a16e5a7c407745aea5f76
Cr-Commit-Position: refs/heads/master@{#32281}

Powered by Google App Engine
This is Rietveld 408576698