components/page_load_metrics/browser/page_load_metrics_util.cc - Issue 1476503004: [page_load_metrics] User Initiated Abort Tracking (Observer version)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1476503004: [page_load_metrics] User Initiated Abort Tracking (Observer version) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_observer

Patch Set: ScopedVector => std::vector Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/page_load_metrics_util.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_util.cc

diff --git a/components/page_load_metrics/browser/page_load_metrics_util.cc b/components/page_load_metrics/browser/page_load_metrics_util.cc

index 9b641e52d0778bed7a72b0b39b2e0bb507f6cc91..843ee873f665657a96e56a5839bc112c3ec88155 100644

--- a/components/page_load_metrics/browser/page_load_metrics_util.cc

+++ b/components/page_load_metrics/browser/page_load_metrics_util.cc

@@ -18,5 +18,11 @@ base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) {

return std::min(timing.first_text_paint, timing.first_image_paint);

}

-} // namespace page_load_metrics

+bool EventOccurredInForeground(const base::TimeDelta& event,

Bryan McQuade 2015/12/09 20:35:24 nice - this seems like a great addition to these u

+ const PageLoadExtraInfo& info) {

+ return info.started_in_foreground && !event.is_zero() &&

+ (info.first_background_time.is_zero() ||

+ event < info.first_background_time);

+} // namespace page_load_metrics