Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_util.cc

Issue 1476503004: [page_load_metrics] User Initiated Abort Tracking (Observer version) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_observer
Patch Set: ScopedVector => std::vector Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_util.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "components/page_load_metrics/common/page_load_timing.h" 9 #include "components/page_load_metrics/common/page_load_timing.h"
10 10
11 namespace page_load_metrics { 11 namespace page_load_metrics {
12 12
13 base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) { 13 base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing) {
14 if (timing.first_text_paint.is_zero()) 14 if (timing.first_text_paint.is_zero())
15 return timing.first_image_paint; 15 return timing.first_image_paint;
16 if (timing.first_image_paint.is_zero()) 16 if (timing.first_image_paint.is_zero())
17 return timing.first_text_paint; 17 return timing.first_text_paint;
18 return std::min(timing.first_text_paint, timing.first_image_paint); 18 return std::min(timing.first_text_paint, timing.first_image_paint);
19 } 19 }
20 20
21 bool EventOccurredInForeground(const base::TimeDelta& event,
Bryan McQuade 2015/12/09 20:35:24 nice - this seems like a great addition to these u
22 const PageLoadExtraInfo& info) {
23 return info.started_in_foreground && !event.is_zero() &&
24 (info.first_background_time.is_zero() ||
25 event < info.first_background_time);
26 }
27
21 } // namespace page_load_metrics 28 } // namespace page_load_metrics
22
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698