Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 1476503004: [page_load_metrics] User Initiated Abort Tracking (Observer version) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_observer
Patch Set: ScopedVector => std::vector Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_util.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h
index b5a569867db22bd488ace4ac2009a0f5f3b4a872..43b66fc4f41860de22a6d677babd68d7e00cd487 100644
--- a/components/page_load_metrics/browser/page_load_metrics_util.h
+++ b/components/page_load_metrics/browser/page_load_metrics_util.h
@@ -7,6 +7,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/time/time.h"
+#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
#define PAGE_LOAD_HISTOGRAM(name, sample) \
UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \
@@ -22,6 +23,14 @@ struct PageLoadTiming;
// Painting of a background color is not considered 'contentful'.
base::TimeDelta GetFirstContentfulPaint(const PageLoadTiming& timing);
+// Returns false for events for which we have no timing information, and events
+// that happened after the page was backgrounded. When a page is backgrounded,
+// some events (e.g. paint) are delayed. Since these data points can skew the
+// mean, they should not be mixed with timing events that occurred in the
+// foreground.
+bool EventOccurredInForeground(const base::TimeDelta& event,
+ const PageLoadExtraInfo& info);
+
} // namespace page_load_metrics
#endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698