Remove ScopedVector from ElementsUploadDataStream

Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289
Committed: https://crrev.com/6df48b2a70996ad8a2cd09872566e4f0edf06724
Cr-Commit-Position: refs/heads/master@{#361841}

[Olli Raula, 2015-11-24 14:05:40]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

BUG=554289
==========

[Olli Raula, 2015-11-24 14:05:40]

olli.raula@intel.com changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org

[Olli Raula, 2015-11-24 14:06:14]

Could you review?

mmenke: net
jochen: chrome, content
maybe we can tbr those 3 remaining files?

[mmenke, 2015-11-24 17:25:08]

On 2015/11/24 14:06:14, Olli Raula wrote:
> Could you review?
> 
> mmenke: net
> jochen: chrome, content
> maybe we can tbr those 3 remaining files?

net/ LGTM.

I think the changes in the 3 files outside net, outside content / chrome are
indeed TBR-worthy.

https://codereview.chromium.org/1476443002/diff/1/extensions/browser/api/web_...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/1476443002/diff/1/extensions/browser/api/web_...
extensions/browser/api/web_request/web_request_api.cc:252: const
std::vector<scoped_ptr<net::UploadElementReader>>* readers =
include <vector>, scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/ios/net/crn_http_protocol_h...
File ios/net/crn_http_protocol_handler.mm (right):

https://codereview.chromium.org/1476443002/diff/1/ios/net/crn_http_protocol_h...
ios/net/crn_http_protocol_handler.mm:196:
std::vector<scoped_ptr<UploadElementReader>> post_data_readers_;
include <vector>, scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/mojo/services/network/url_l...
File mojo/services/network/url_loader_impl.cc (right):

https://codereview.chromium.org/1476443002/diff/1/mojo/services/network/url_l...
mojo/services/network/url_loader_impl.cc:7: #include
"base/memory/scoped_vector.h"
Remove this line.

https://codereview.chromium.org/1476443002/diff/1/mojo/services/network/url_l...
mojo/services/network/url_loader_impl.cc:193:
std::vector<scoped_ptr<net::UploadElementReader>> element_readers;
include <vector>, scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/net/base/elements_upload_da...
File net/base/elements_upload_data_stream.h (right):

https://codereview.chromium.org/1476443002/diff/1/net/base/elements_upload_da...
net/base/elements_upload_data_stream.h:26:
std::vector<scoped_ptr<UploadElementReader>> element_readers,
Need to include <vector>

https://codereview.chromium.org/1476443002/diff/1/net/base/upload_data_stream.h
File net/base/upload_data_stream.h (right):

https://codereview.chromium.org/1476443002/diff/1/net/base/upload_data_stream...
net/base/upload_data_stream.h:90: virtual const
std::vector<scoped_ptr<UploadElementReader>>*
include scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/net/http/http_cache_unittes...
File net/http/http_cache_unittest.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/http/http_cache_unittes...
net/http/http_cache_unittest.cc:1416: std::vector<scoped_ptr<Context>>
context_list;
Changes in this file don't seem to fit the CL description.  Suggest just
expanding the description a bit.

https://codereview.chromium.org/1476443002/diff/1/net/http/http_cache_unittes...
net/http/http_cache_unittest.cc:1416: std::vector<scoped_ptr<Context>>
context_list;
include vector, scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:14878: make_scoped_ptr(new
UploadBytesElementReader("foo", 3)));
This doesn't seem to be removed.  Just remove it?

https://codereview.chromium.org/1476443002/diff/1/net/http/http_stream_parser...
File net/http/http_stream_parser_unittest.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/http/http_stream_parser...
net/http/http_stream_parser_unittest.cc:130: scoped_ptr<UploadDataStream>
body(make_scoped_ptr(
include scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/net/quic/quic_end_to_end_un...
File net/quic/quic_end_to_end_unittest.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/quic/quic_end_to_end_un...
net/quic/quic_end_to_end_unittest.cc:199:
std::vector<scoped_ptr<UploadElementReader>> element_readers;
include vector

https://codereview.chromium.org/1476443002/diff/1/net/quic/quic_http_stream_t...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/quic/quic_http_stream_t...
net/quic/quic_http_stream_test.cc:522:
element_readers.push_back(make_scoped_ptr(
include scoped_ptr

https://codereview.chromium.org/1476443002/diff/1/net/spdy/spdy_network_trans...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1476443002/diff/1/net/spdy/spdy_network_trans...
net/spdy/spdy_network_transaction_unittest.cc:462:
std::vector<scoped_ptr<UploadElementReader>> element_readers;
include scoped_ptr

[jochen (gone - plz use gerrit), 2015-11-25 08:54:49]

lgtm

[Olli Raula, 2015-11-25 09:43:53]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest

BUG=554289
==========

[Olli Raula, 2015-11-25 15:59:40]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

BUG=554289
==========

[Olli Raula, 2015-11-26 07:13:19]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-11-26 07:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1476443002/#ps20001
(title: "Fix")

[commit-bot: I haz the power, 2015-11-26 07:13:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476443002/20001

[commit-bot: I haz the power, 2015-11-26 07:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 07:21:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Olli Raula, 2015-11-26 07:35:41]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289
==========

[Olli Raula, 2015-11-26 07:35:50]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-11-26 07:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476443002/20001

[commit-bot: I haz the power, 2015-11-26 07:40:30]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289
==========

[commit-bot: I haz the power, 2015-11-26 07:40:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 07:41:44]

Description was changed from

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289
==========

to

==========
Remove ScopedVector from ElementsUploadDataStream

Also made related small refactorings in http_cache_unittest and remove some
unused variables from http_network_transaction_unittest

TBR=jam@chromium.org

BUG=554289

Committed: https://crrev.com/6df48b2a70996ad8a2cd09872566e4f0edf06724
Cr-Commit-Position: refs/heads/master@{#361841}
==========

[commit-bot: I haz the power, 2015-11-26 07:41:45]

Patchset 2 (id:??) landed as
https://crrev.com/6df48b2a70996ad8a2cd09872566e4f0edf06724
Cr-Commit-Position: refs/heads/master@{#361841}