Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: mojo/services/network/url_loader_impl.cc

Issue 1476443002: Remove ScopedVector from ElementsUploadDataStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/network/url_loader_impl.h" 5 #include "mojo/services/network/url_loader_impl.h"
6 6
7 #include "base/memory/scoped_vector.h" 7 #include "base/memory/scoped_vector.h"
mmenke 2015/11/24 17:25:08 Remove this line.
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "mojo/common/common_type_converters.h" 9 #include "mojo/common/common_type_converters.h"
10 #include "mojo/common/url_type_converters.h" 10 #include "mojo/common/url_type_converters.h"
11 #include "mojo/services/network/net_adapters.h" 11 #include "mojo/services/network/net_adapters.h"
12 #include "mojo/services/network/network_context.h" 12 #include "mojo/services/network/network_context.h"
13 #include "net/base/elements_upload_data_stream.h" 13 #include "net/base/elements_upload_data_stream.h"
14 #include "net/base/io_buffer.h" 14 #include "net/base/io_buffer.h"
15 #include "net/base/load_flags.h" 15 #include "net/base/load_flags.h"
16 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 16 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
17 #include "net/base/upload_bytes_element_reader.h" 17 #include "net/base/upload_bytes_element_reader.h"
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 request->headers[i]->value.To<base::StringPiece>(); 183 request->headers[i]->value.To<base::StringPiece>();
184 if (header == net::HttpRequestHeaders::kReferer) { 184 if (header == net::HttpRequestHeaders::kReferer) {
185 url_request_->SetReferrer(value.as_string()); 185 url_request_->SetReferrer(value.as_string());
186 } else { 186 } else {
187 headers.SetHeader(header, value); 187 headers.SetHeader(header, value);
188 } 188 }
189 } 189 }
190 url_request_->SetExtraRequestHeaders(headers); 190 url_request_->SetExtraRequestHeaders(headers);
191 } 191 }
192 if (request->body) { 192 if (request->body) {
193 ScopedVector<net::UploadElementReader> element_readers; 193 std::vector<scoped_ptr<net::UploadElementReader>> element_readers;
mmenke 2015/11/24 17:25:08 include <vector>, scoped_ptr
194 for (size_t i = 0; i < request->body.size(); ++i) { 194 for (size_t i = 0; i < request->body.size(); ++i) {
195 element_readers.push_back( 195 element_readers.push_back(make_scoped_ptr(
196 new UploadDataPipeElementReader(request->body[i].Pass())); 196 new UploadDataPipeElementReader(request->body[i].Pass())));
197 } 197 }
198 url_request_->set_upload(make_scoped_ptr<net::UploadDataStream>( 198 url_request_->set_upload(make_scoped_ptr<net::UploadDataStream>(
199 new net::ElementsUploadDataStream(element_readers.Pass(), 0))); 199 new net::ElementsUploadDataStream(std::move(element_readers), 0)));
200 } 200 }
201 if (request->bypass_cache) 201 if (request->bypass_cache)
202 url_request_->SetLoadFlags(net::LOAD_BYPASS_CACHE); 202 url_request_->SetLoadFlags(net::LOAD_BYPASS_CACHE);
203 203
204 callback_ = callback; 204 callback_ = callback;
205 response_body_buffer_size_ = request->response_body_buffer_size; 205 response_body_buffer_size_ = request->response_body_buffer_size;
206 auto_follow_redirects_ = request->auto_follow_redirects; 206 auto_follow_redirects_ = request->auto_follow_redirects;
207 207
208 url_request_->Start(); 208 url_request_->Start();
209 } 209 }
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 403
404 void URLLoaderImpl::ListenForPeerClosed() { 404 void URLLoaderImpl::ListenForPeerClosed() {
405 handle_watcher_.Start(response_body_stream_.get(), 405 handle_watcher_.Start(response_body_stream_.get(),
406 MOJO_HANDLE_SIGNAL_PEER_CLOSED, 406 MOJO_HANDLE_SIGNAL_PEER_CLOSED,
407 MOJO_DEADLINE_INDEFINITE, 407 MOJO_DEADLINE_INDEFINITE,
408 base::Bind(&URLLoaderImpl::OnResponseBodyStreamClosed, 408 base::Bind(&URLLoaderImpl::OnResponseBodyStreamClosed,
409 base::Unretained(this))); 409 base::Unretained(this)));
410 } 410 }
411 411
412 } // namespace mojo 412 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698