Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: net/base/elements_upload_data_stream.h

Issue 1476443002: Remove ScopedVector from ElementsUploadDataStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_ 5 #ifndef NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_
6 #define NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_ 6 #define NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/memory/scoped_vector.h"
13 #include "base/memory/weak_ptr.h" 12 #include "base/memory/weak_ptr.h"
14 #include "net/base/net_export.h" 13 #include "net/base/net_export.h"
15 #include "net/base/upload_data_stream.h" 14 #include "net/base/upload_data_stream.h"
16 15
17 namespace net { 16 namespace net {
18 17
19 class DrainableIOBuffer; 18 class DrainableIOBuffer;
20 class IOBuffer; 19 class IOBuffer;
21 class UploadElementReader; 20 class UploadElementReader;
22 21
23 // A non-chunked UploadDataStream consisting of one or more UploadElements. 22 // A non-chunked UploadDataStream consisting of one or more UploadElements.
24 class NET_EXPORT ElementsUploadDataStream : public UploadDataStream { 23 class NET_EXPORT ElementsUploadDataStream : public UploadDataStream {
25 public: 24 public:
26 ElementsUploadDataStream(ScopedVector<UploadElementReader> element_readers, 25 ElementsUploadDataStream(
27 int64_t identifier); 26 std::vector<scoped_ptr<UploadElementReader>> element_readers,
mmenke 2015/11/24 17:25:08 Need to include <vector>
27 int64_t identifier);
28 28
29 ~ElementsUploadDataStream() override; 29 ~ElementsUploadDataStream() override;
30 30
31 // Creates an ElementsUploadDataStream with a single reader. Returns a 31 // Creates an ElementsUploadDataStream with a single reader. Returns a
32 // scoped_ptr<UploadDataStream> for ease of use. 32 // scoped_ptr<UploadDataStream> for ease of use.
33 static scoped_ptr<UploadDataStream> CreateWithReader( 33 static scoped_ptr<UploadDataStream> CreateWithReader(
34 scoped_ptr<UploadElementReader> reader, 34 scoped_ptr<UploadElementReader> reader,
35 int64_t identifier); 35 int64_t identifier);
36 36
37 private: 37 private:
38 // UploadDataStream implementation. 38 // UploadDataStream implementation.
39 bool IsInMemory() const override; 39 bool IsInMemory() const override;
40 const ScopedVector<UploadElementReader>* GetElementReaders() const override; 40 const std::vector<scoped_ptr<UploadElementReader>>* GetElementReaders()
41 const override;
41 int InitInternal() override; 42 int InitInternal() override;
42 int ReadInternal(IOBuffer* buf, int buf_len) override; 43 int ReadInternal(IOBuffer* buf, int buf_len) override;
43 void ResetInternal() override; 44 void ResetInternal() override;
44 45
45 // Runs Init() for all element readers. 46 // Runs Init() for all element readers.
46 // This method is used to implement InitInternal(). 47 // This method is used to implement InitInternal().
47 int InitElements(size_t start_index); 48 int InitElements(size_t start_index);
48 49
49 // Called when the |index| element finishes initialization. If it succeeded, 50 // Called when the |index| element finishes initialization. If it succeeded,
50 // continues with the |index + 1| element. Calls OnInitCompleted on error or 51 // continues with the |index + 1| element. Calls OnInitCompleted on error or
51 // when all elements have been initialized. 52 // when all elements have been initialized.
52 void OnInitElementCompleted(size_t index, int result); 53 void OnInitElementCompleted(size_t index, int result);
53 54
54 // Reads data from the element readers. 55 // Reads data from the element readers.
55 // This method is used to implement Read(). 56 // This method is used to implement Read().
56 int ReadElements(const scoped_refptr<DrainableIOBuffer>& buf); 57 int ReadElements(const scoped_refptr<DrainableIOBuffer>& buf);
57 58
58 // Resumes pending read and calls OnReadCompleted with a result when 59 // Resumes pending read and calls OnReadCompleted with a result when
59 // necessary. 60 // necessary.
60 void OnReadElementCompleted(const scoped_refptr<DrainableIOBuffer>& buf, 61 void OnReadElementCompleted(const scoped_refptr<DrainableIOBuffer>& buf,
61 int result); 62 int result);
62 63
63 // Processes result of UploadElementReader::Read(). If |result| indicates 64 // Processes result of UploadElementReader::Read(). If |result| indicates
64 // success, updates |buf|'s offset. Otherwise, sets |read_failed_| to true. 65 // success, updates |buf|'s offset. Otherwise, sets |read_failed_| to true.
65 void ProcessReadResult(const scoped_refptr<DrainableIOBuffer>& buf, 66 void ProcessReadResult(const scoped_refptr<DrainableIOBuffer>& buf,
66 int result); 67 int result);
67 68
68 ScopedVector<UploadElementReader> element_readers_; 69 std::vector<scoped_ptr<UploadElementReader>> element_readers_;
69 70
70 // Index of the current upload element (i.e. the element currently being 71 // Index of the current upload element (i.e. the element currently being
71 // read). The index is used as a cursor to iterate over elements in 72 // read). The index is used as a cursor to iterate over elements in
72 // |upload_data_|. 73 // |upload_data_|.
73 size_t element_index_; 74 size_t element_index_;
74 75
75 // True if an error occcured during read operation. 76 // True if an error occcured during read operation.
76 bool read_failed_; 77 bool read_failed_;
77 78
78 base::WeakPtrFactory<ElementsUploadDataStream> weak_ptr_factory_; 79 base::WeakPtrFactory<ElementsUploadDataStream> weak_ptr_factory_;
79 80
80 DISALLOW_COPY_AND_ASSIGN(ElementsUploadDataStream); 81 DISALLOW_COPY_AND_ASSIGN(ElementsUploadDataStream);
81 }; 82 };
82 83
83 } // namespace net 84 } // namespace net
84 85
85 #endif // NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_ 86 #endif // NET_BASE_ELEMENTS_UPLOAD_DATA_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698