jni: Pass method parameters as JavaParamRef in base.

jni: Pass method parameters as JavaParamRef in base.

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

Also tidy up the code in sample_for_tests to make it easier to use as an
example.

BUG=506850
Committed: https://crrev.com/70f3fac9eba163c6b59ca23e88f720a035312394
Cr-Commit-Position: refs/heads/master@{#362730}

[Torne, 2015-11-27 12:54:18]

torne@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2015-12-02 01:35:43]

lgtm.

A couple of comments regarding namespace, but otherwise looks good. Feel free to
submit either like it is today or with changes.

https://codereview.chromium.org/1476403003/diff/1/base/android/java_handler_t...
File base/android/java_handler_thread.h (right):

https://codereview.chromium.org/1476403003/diff/1/base/android/java_handler_t...
base/android/java_handler_thread.h:37: const
base::android::JavaParamRef<jobject>& obj,
We're already in base::android namespace. Is namespace really necessary here?

https://codereview.chromium.org/1476403003/diff/1/base/android/jni_generator/...
File base/android/jni_generator/sample_for_tests.h (right):

https://codereview.chromium.org/1476403003/diff/1/base/android/jni_generator/...
base/android/jni_generator/sample_for_tests.h:152: const
base::android::JavaParamRef<jobject>& caller);
This is also base::android already. Did you keep base::android because this is
for documentation purposes?

[Torne, 2015-12-02 15:15:08]

On 2015/12/02 01:35:43, nyquist wrote:
> lgtm.
> 
> A couple of comments regarding namespace, but otherwise looks good. Feel free
to
> submit either like it is today or with changes.
> 
>
https://codereview.chromium.org/1476403003/diff/1/base/android/java_handler_t...
> File base/android/java_handler_thread.h (right):
> 
>
https://codereview.chromium.org/1476403003/diff/1/base/android/java_handler_t...
> base/android/java_handler_thread.h:37: const
> base::android::JavaParamRef<jobject>& obj,
> We're already in base::android namespace. Is namespace really necessary here?

No, I'll remove it. This was a massive scripted change across the whole
codebase, it didn't have any special case for base. ;)

>
https://codereview.chromium.org/1476403003/diff/1/base/android/jni_generator/...
> File base/android/jni_generator/sample_for_tests.h (right):
> 
>
https://codereview.chromium.org/1476403003/diff/1/base/android/jni_generator/...
> base/android/jni_generator/sample_for_tests.h:152: const
> base::android::JavaParamRef<jobject>& caller);
> This is also base::android already. Did you keep base::android because this is
> for documentation purposes?

I didn't really think about this, but yes, I do want to leave it here for
documentation purposes (we don't want people to add "using" in header files).

[Torne, 2015-12-02 15:17:29]

The CQ bit was checked by torne@chromium.org

[Torne, 2015-12-02 15:17:30]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1476403003/#ps20001
(title: "Remove unnecessary namespace qualifiers")

[commit-bot: I haz the power, 2015-12-02 15:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476403003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476403003/20001

[commit-bot: I haz the power, 2015-12-02 16:31:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 16:32:51]

Description was changed from

==========
jni: Pass method parameters as JavaParamRef in base.

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

Also tidy up the code in sample_for_tests to make it easier to use as an
example.

BUG=506850
==========

to

==========
jni: Pass method parameters as JavaParamRef in base.

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

Also tidy up the code in sample_for_tests to make it easier to use as an
example.

BUG=506850

Committed: https://crrev.com/70f3fac9eba163c6b59ca23e88f720a035312394
Cr-Commit-Position: refs/heads/master@{#362730}
==========

[commit-bot: I haz the power, 2015-12-02 16:32:52]

Patchset 2 (id:??) landed as
https://crrev.com/70f3fac9eba163c6b59ca23e88f720a035312394
Cr-Commit-Position: refs/heads/master@{#362730}

[nyquist, 2015-12-02 17:55:00]

>
https://codereview.chromium.org/1476403003/diff/1/base/android/jni_generator/...
> > base/android/jni_generator/sample_for_tests.h:152: const
> > base::android::JavaParamRef<jobject>& caller);
> > This is also base::android already. Did you keep base::android because this
is
> > for documentation purposes?
> 
> I didn't really think about this, but yes, I do want to leave it here for
> documentation purposes (we don't want people to add "using" in header files).

Yeah, that's what I was hoping you'd say :-)