Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: base/android/java_handler_thread.cc

Issue 1476403003: jni: Pass method parameters as JavaParamRef in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary namespace qualifiers Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/java_handler_thread.h ('k') | base/android/jni_generator/sample_for_tests.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/java_handler_thread.h" 5 #include "base/android/java_handler_thread.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 base::WaitableEvent shutdown_event(false, false); 48 base::WaitableEvent shutdown_event(false, false);
49 Java_JavaHandlerThread_stop(env, 49 Java_JavaHandlerThread_stop(env,
50 java_thread_.obj(), 50 java_thread_.obj(),
51 reinterpret_cast<intptr_t>(this), 51 reinterpret_cast<intptr_t>(this),
52 reinterpret_cast<intptr_t>(&shutdown_event)); 52 reinterpret_cast<intptr_t>(&shutdown_event));
53 // Wait for thread to shut down before returning. 53 // Wait for thread to shut down before returning.
54 base::ThreadRestrictions::ScopedAllowWait wait_allowed; 54 base::ThreadRestrictions::ScopedAllowWait wait_allowed;
55 shutdown_event.Wait(); 55 shutdown_event.Wait();
56 } 56 }
57 57
58 void JavaHandlerThread::InitializeThread(JNIEnv* env, jobject obj, 58 void JavaHandlerThread::InitializeThread(JNIEnv* env,
59 const JavaParamRef<jobject>& obj,
59 jlong event) { 60 jlong event) {
60 // TYPE_JAVA to get the Android java style message loop. 61 // TYPE_JAVA to get the Android java style message loop.
61 message_loop_.reset(new base::MessageLoop(base::MessageLoop::TYPE_JAVA)); 62 message_loop_.reset(new base::MessageLoop(base::MessageLoop::TYPE_JAVA));
62 static_cast<MessageLoopForUI*>(message_loop_.get())->Start(); 63 static_cast<MessageLoopForUI*>(message_loop_.get())->Start();
63 reinterpret_cast<base::WaitableEvent*>(event)->Signal(); 64 reinterpret_cast<base::WaitableEvent*>(event)->Signal();
64 } 65 }
65 66
66 void JavaHandlerThread::StopThread(JNIEnv* env, jobject obj, jlong event) { 67 void JavaHandlerThread::StopThread(JNIEnv* env,
68 const JavaParamRef<jobject>& obj,
69 jlong event) {
67 static_cast<MessageLoopForUI*>(message_loop_.get())->QuitWhenIdle(); 70 static_cast<MessageLoopForUI*>(message_loop_.get())->QuitWhenIdle();
68 reinterpret_cast<base::WaitableEvent*>(event)->Signal(); 71 reinterpret_cast<base::WaitableEvent*>(event)->Signal();
69 } 72 }
70 73
71 // static 74 // static
72 bool JavaHandlerThread::RegisterBindings(JNIEnv* env) { 75 bool JavaHandlerThread::RegisterBindings(JNIEnv* env) {
73 return RegisterNativesImpl(env); 76 return RegisterNativesImpl(env);
74 } 77 }
75 78
76 } // namespace android 79 } // namespace android
77 } // namespace base 80 } // namespace base
OLDNEW
« no previous file with comments | « base/android/java_handler_thread.h ('k') | base/android/jni_generator/sample_for_tests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698