Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: base/android/jni_generator/sample_for_tests.h

Issue 1476403003: jni: Pass method parameters as JavaParamRef in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary namespace qualifiers Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java_handler_thread.cc ('k') | base/android/jni_generator/sample_for_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/sample_for_tests.h
diff --git a/base/android/jni_generator/sample_for_tests.h b/base/android/jni_generator/sample_for_tests.h
index 5366faf2a8897aeee9fd03b5ef7244d12cd15c42..42ba84b07591b8a2721d764ed704e0a920d85745 100644
--- a/base/android/jni_generator/sample_for_tests.h
+++ b/base/android/jni_generator/sample_for_tests.h
@@ -148,19 +148,25 @@ class CPPClass {
class InnerClass {
public:
- jdouble MethodOtherP0(JNIEnv* env, jobject caller);
+ jdouble MethodOtherP0(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& caller);
};
- void Destroy(JNIEnv* env, jobject caller);
+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& caller);
- jint Method(JNIEnv* env, jobject caller);
+ jint Method(JNIEnv* env, const base::android::JavaParamRef<jobject>& caller);
- void AddStructB(JNIEnv* env, jobject caller, jobject structb);
+ void AddStructB(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& caller,
+ const base::android::JavaParamRef<jobject>& structb);
- void IterateAndDoSomethingWithStructB(JNIEnv* env, jobject caller);
+ void IterateAndDoSomethingWithStructB(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& caller);
base::android::ScopedJavaLocalRef<jstring> ReturnAString(
- JNIEnv* env, jobject caller);
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& caller);
private:
std::map<long, std::string> map_;
« no previous file with comments | « base/android/java_handler_thread.cc ('k') | base/android/jni_generator/sample_for_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698