buildbot UI: add linkification of Rietveld issue URL to build page.

buildbot UI: add linkification of Rietveld issue URL to build page.

R=nodir@chromium.org,dpranke@chromium.org
CC=sergiyb@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297728

[tandrii(chromium), 2015-11-25 22:48:07]

PTAL as you've asked, nodir :)

[Dirk Pranke, 2015-11-25 22:59:07]

more-or-less lgtm, though I'm surprised that we either have a custom template
for tryserver.chromium.linux, or that we don't also have them for
tryserver.chromium.mac, etc.

[tandrii(chromium), 2015-11-26 10:12:29]

On 2015/11/25 22:59:07, Dirk Pranke wrote:
> more-or-less lgtm, though I'm surprised that we either have a custom template
> for tryserver.chromium.linux, or that we don't also have them for
> tryserver.chromium.mac, etc.
mac and other chromium tryservers use .linux templates.

[tandrii(chromium), 2015-11-26 10:12:43]

tandrii@chromium.org changed reviewers:
+ sergiyb@chromium.org

[Sergiy Byelozyorov, 2015-11-26 15:10:34]

lgtm w/ comment

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
File masters/master.chromium/templates/build.html (right):

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
masters/master.chromium/templates/build.html:175: {% else %}{% set rietveld_url
= '' %}{% endfor %}
please structure it with indents, e.g.

{% for p in properties %}
  {% if p.name == 'rietveld' %}
    {% set rietveld_url = p.value %}

when you do you'll discover a bug :-)

make similar change to
masters/master.tryserver.chromium.linux/templates/build.html

[tandrii(chromium), 2015-11-26 15:18:37]

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
File masters/master.chromium/templates/build.html (right):

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
masters/master.chromium/templates/build.html:175: {% else %}{% set rietveld_url
= '' %}{% endfor %}
On 2015/11/26 15:10:34, Sergiy Byelozyorov wrote:
> please structure it with indents, e.g.
> 
> {% for p in properties %}
>   {% if p.name == 'rietveld' %}
>     {% set rietveld_url = p.value %}
> 
> when you do you'll discover a bug :-)
> 
> make similar change to
> masters/master.tryserver.chromium.linux/templates/build.html

Done, but I don't see a bug.

[Sergiy Byelozyorov, 2015-11-27 12:17:14]

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
File masters/master.chromium/templates/build.html (right):

https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
masters/master.chromium/templates/build.html:175: {% else %}{% set rietveld_url
= '' %}{% endfor %}
On 2015/11/26 15:18:37, tandrii(chromium) wrote:
> On 2015/11/26 15:10:34, Sergiy Byelozyorov wrote:
> > please structure it with indents, e.g.
> > 
> > {% for p in properties %}
> >   {% if p.name == 'rietveld' %}
> >     {% set rietveld_url = p.value %}
> > 
> > when you do you'll discover a bug :-)
> > 
> > make similar change to
> > masters/master.tryserver.chromium.linux/templates/build.html
> 
> Done, but I don't see a bug.

else for for? afaik, this only works in python

[tandrii(chromium), 2015-11-27 12:24:12]

On 2015/11/27 12:17:14, Sergiy Byelozyorov wrote:
>
https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
> File masters/master.chromium/templates/build.html (right):
> 
>
https://codereview.chromium.org/1476173002/diff/20001/masters/master.chromium...
> masters/master.chromium/templates/build.html:175: {% else %}{% set
rietveld_url
> = '' %}{% endfor %}
> On 2015/11/26 15:18:37, tandrii(chromium) wrote:
> > On 2015/11/26 15:10:34, Sergiy Byelozyorov wrote:
> > > please structure it with indents, e.g.
> > > 
> > > {% for p in properties %}
> > >   {% if p.name == 'rietveld' %}
> > >     {% set rietveld_url = p.value %}
> > > 
> > > when you do you'll discover a bug :-)
> > > 
> > > make similar change to
> > > masters/master.tryserver.chromium.linux/templates/build.html
> > 
> > Done, but I don't see a bug.
> 
> else for for? afaik, this only works in python

hm, for .. else is certainly supported in ninja
(http://jinja.pocoo.org/docs/dev/templates/), but I didn't break from the loop,
so there is a bug,
thank you very much!

[tandrii(chromium), 2015-11-27 12:50:48]

AND FIXED with good old trick of modifying list.

[tandrii(chromium), 2015-11-27 12:51:04]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2015-11-27 12:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/1476173002/#ps60001
(title: "thanks,sergiyb@")

[commit-bot: I haz the power, 2015-11-27 12:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476173002/60001

[commit-bot: I haz the power, 2015-11-27 12:53:35]

Description was changed from

==========
buildbot UI: add linkification of Rietveld issue URL to build page.

R=nodir@chromium.org,dpranke@chromium.org
CC=sergiyb@chromium.org
BUG=
==========

to

==========
buildbot UI: add linkification of Rietveld issue URL to build page.

R=nodir@chromium.org,dpranke@chromium.org
CC=sergiyb@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297728
==========

[commit-bot: I haz the power, 2015-11-27 12:53:36]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297728

[shishkander, 2015-11-27 13:16:48]

shishkander@gmail.com changed reviewers:
+ shishkander@gmail.com

[shishkander, 2015-11-27 13:16:49]

and it works:
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...