buildbot UI: add linkification of Rietveld issue URL to build page.

masters/master.chromium/templates/build.html

 {% extends "layout.html" %}
 {% import 'forms.html' as forms %}
 {% from "change_macros.html" import change with context %}
 
 {% block content %}
 
 <h1>
 Builder <a href="{{ path_to_builder }}">{{ b.getBuilder().getName() }}</a>
 Build #{{ b.getNumber() }}
 <div class="bbp_placeholder"
      id="{{ b.getProperty('mastername') }}:{{ b.getBuilder().getName() }}:{{
             b.getNumber() }}">
 </div>
 </h1>
 
 <div class="column">
 
 {% if not b.isFinished() %}
   <h2>Build In Progress:</h2>
 
   {% if when_time %}
     <p>ETA: {{ when_time }} [{{ when }}]</p>
   {% endif %}
 
   {{ current_step }}
-  
+
   {% if authz.advertiseAction('stopBuild') %}
     <h2>Stop Build</h2>
     {{ forms.stop_build(build_url+"/stop", authz, on_all=False, short=False, label='This Build') }}
   {% endif %}
 {% else %}
   <h2>Results:</h2>
 
-  <p class="{{ result_css }} result">   
+  <p class="{{ result_css }} result">
     {{ b.getText()|join(' ')|capitalize }}
   </p>
-   
+
   {% if b.getTestResults() %}
     <h3><a href="{{ tests_link }}"/></h3>
   {% endif %}
 {% endif %}
 
 <h2>SourceStamp:</h2>
 
 <table class="info" width="100%">
 {% set ss_class = cycler('alt','') %}
 
@@ skipping 28 matching lines @@
 {% if most_recent_rev_build %}
   <tr class="{{ ss_class.next() }}"><td class="left" colspan="2">Build of most recent revision</td></tr>
 {% endif %}
 
 </table>
 
 {#
  # TODO: turn this into a table, or some other sort of definition-list
  # that doesn't take up quite so much vertical space
  #}
-   
+
 <h2>BuildSlave:</h2>
-  
-{% if slave_url %}  
+
+{% if slave_url %}
   <a href="{{ slave_url|e }}">{{ b.getSlavename()|e }}</a>
 {% else %}
-  {{ b.getSlavename()|e }} 
+  {{ b.getSlavename()|e }}
 {% endif %}
 
 <h2>Reason:</h2>
 <p>
 {{ b.getReason()|e }}
 </p>
 
 <h2>Steps and Logfiles:</h2>
 
 {#
@@ skipping 61 matching lines @@
 {% endfor %}
 
 </div>
 <div class="column">
 
 <h2>Build Properties:</h2>
 
 <table class="info BuildProperties" width="100%">
 <tr><th>Name</th><th>Value</th><th>Source</th></tr>
 
+{% for p in properties %}{% if p.name == 'rietveld' %} {% set rietveld_url = p.value %}{% endif %}
+{% else %}{% set rietveld_url = '' %}{% endfor %}

[Sergiy Byelozyorov, 2015/11/26 15:10:34]

please structure it with indents, e.g.

{% for p in properties %}
  {% if p.name == 'rietveld' %}
    {% set rietveld_url = p.value %}

when you do you'll discover a bug :-)

make similar change to
masters/master.tryserver.chromium.linux/templates/build.html

[tandrii(chromium), 2015/11/26 15:18:37]

Done, but I don't see a bug.

[Sergiy Byelozyorov, 2015/11/27 12:17:13]

else for for? afaik, this only works in python

+
 {% for p in properties %}
   <tr class="{{ loop.cycle('alt', '') }}">
     <td class="left">{{ p.name|e }}</td>
     <td class="middle"><abbr title="
       {% if p.short_value %}
         {{ p.short_value|e }} .. [property value too long]
       {% else %}
         {{ p.value|e }}
       {% endif %}">
     {% if p.short_value %}
       {{ p.short_value|e }} .. [property value too long]
+    {% elif p.name == 'issue' and rietveld_url %}
+      <a style="color: red" href="{{ (rietveld_url + '/' + p.value)|e }} ">{{ p.value|e }}</a>
     {% else %}
       {{ p.value|e }}
     {% endif %}
     </abbr></td>
     <td>{{ p.source|e }}</td>
   </tr>
 {% endfor %}
 
 </table>
 
@@ skipping 20 matching lines @@
 </table>
 
   {% if authz.advertiseAction('forceBuild') %}
     <h3>Resubmit Build:</h3>
     {{ forms.rebuild_build(build_url+"/rebuild", authz, exactly, ss) }}
   {% endif %}
 
 </div>
 
 <br style="clear:both"/>
-  
+
 {% if ss.changes %}
 <div class="column">
   <h2>All Changes:</h2>
   <ol>
   {% for c in ss.changes %}
     <li><h3>Change #{{ c.number }}</h3>
       {{ change(c.asDict()) }}
     </li>
   {% else %}
     <li>no changes</li>
-  {% endfor %}  
+  {% endfor %}
   </ol>
-</div> 
+</div>
 {% endif %}
 
 {% endblock %}