Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: masters/master.tryserver.chromium.linux/templates/build.html

Issue 1476173002: buildbot UI: add linkification of Rietveld issue URL to build page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: thanks,sergiyb@ Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.chromium/templates/build.html ('k') | masters/master.tryserver.infra/builders.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.tryserver.chromium.linux/templates/build.html
diff --git a/masters/master.tryserver.chromium.linux/templates/build.html b/masters/master.tryserver.chromium.linux/templates/build.html
index 0bf2a5c931dfc6cbb4c6a4179a0d8d0dde8b1f3e..db5001f14c523d1a4b57822fee0168270d9a55bb 100644
--- a/masters/master.tryserver.chromium.linux/templates/build.html
+++ b/masters/master.tryserver.chromium.linux/templates/build.html
@@ -23,7 +23,7 @@ Build #{{ b.getNumber() }}
{% endif %}
{{ current_step }}
-
+
{% if authz.advertiseAction('stopBuild') %}
<h2>Stop Build</h2>
{{ forms.stop_build(build_url+"/stop", authz, on_all=False, short=False, label='This Build') }}
@@ -31,10 +31,10 @@ Build #{{ b.getNumber() }}
{% else %}
<h2>Results:</h2>
- <p class="{{ result_css }} result">
+ <p class="{{ result_css }} result">
{{ b.getText()|join(' ')|capitalize }}
</p>
-
+
{% if b.getTestResults() %}
<h3><a href="{{ tests_link }}"/></h3>
{% endif %}
@@ -83,13 +83,13 @@ Build #{{ b.getNumber() }}
# TODO: turn this into a table, or some other sort of definition-list
# that doesn't take up quite so much vertical space
#}
-
+
<h2>BuildSlave:</h2>
-
-{% if slave_url %}
+
+{% if slave_url %}
<a href="{{ slave_url|e }}">{{ b.getSlavename()|e }}</a>
{% else %}
- {{ b.getSlavename()|e }}
+ {{ b.getSlavename()|e }}
{% endif %}
<h2>Reason:</h2>
@@ -137,7 +137,7 @@ Build #{{ b.getNumber() }}
{% set nest_level = step_nest %}
<div class="{{ s.css_class }} result">
- <a href="{{ s.link }}">{{ s.name }}</a>
+ <a href="{{ s.link }}">{{ s.name }}</a>
{% set previous_name = s.name %}
{{ s.text }}&nbsp;<span style="float:right">{{ '( ' + s.time_to_run + ' )' if s.time_to_run else '' }}</span>
</div>
@@ -155,11 +155,11 @@ Build #{{ b.getNumber() }}
{% else %}
<li class="{{ item_class.next() }}">- no logs -</li>
{% endfor %}
-
+
{% for u in s.urls %}
<li class="{{ item_class.next() }}"><a href="{{ u.url }}">{{ u.logname }}</a></li>
{% endfor %}
- </ul>
+ </ul>
</li>
{% endfor %}
@@ -176,6 +176,12 @@ Build #{{ b.getNumber() }}
<table class="info BuildProperties" width="100%">
<tr><th>Name</th><th>Value</th><th>Source</th></tr>
+{% set rietveld_url = [] %}
+{% for p in properties %}
+ {% if p.name == 'rietveld' and rietveld_url.append(p.value) %}
+ {% endif %}
+{% endfor %}
+
{% for p in properties %}
<tr class="{{ loop.cycle('alt', '') }}">
<td class="left">{{ p.name|e }}</td>
@@ -187,6 +193,8 @@ Build #{{ b.getNumber() }}
{% endif %}">
{% if p.short_value %}
{{ p.short_value|e }} .. [property value too long]
+ {% elif p.name == 'issue' and rietveld_url %}
+ <a style="color: red" href="{{ (rietveld_url[0] + '/' + p.value)|e }} ">{{ p.value|e }}</a>
{% else %}
{{ p.value|e }}
{% endif %}
@@ -227,7 +235,7 @@ Build #{{ b.getNumber() }}
</div>
<br style="clear:both"/>
-
+
{% if ss.changes %}
<div class="column">
<h2>All Changes:</h2>
@@ -238,9 +246,9 @@ Build #{{ b.getNumber() }}
</li>
{% else %}
<li>no changes</li>
- {% endfor %}
+ {% endfor %}
</ol>
-</div>
+</div>
{% endif %}
{% endblock %}
« no previous file with comments | « masters/master.chromium/templates/build.html ('k') | masters/master.tryserver.infra/builders.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698