Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. (Closed)

Created:
7 years, 7 months ago by mvstanton
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14599

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Michael, here is a parallel compilation issue found when we use [H|L]CallNewArray. The fix ...
7 years, 7 months ago (2013-05-08 09:29:53 UTC) #1
Michael Starzinger
LGTM, with one suggestion. https://codereview.chromium.org/14761010/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14761010/diff/1/src/hydrogen-instructions.h#newcode2362 src/hydrogen-instructions.h:2362: ElementsKind kind() const { return ...
7 years, 7 months ago (2013-05-08 10:40:30 UTC) #2
mvstanton
Committed patchset #2 manually as r14599 (presubmit successful).
7 years, 7 months ago (2013-05-08 16:48:34 UTC) #3
mvstanton
7 years, 7 months ago (2013-05-08 16:48:42 UTC) #4
Message was sent while issue was closed.
Thanks, done!

On 2013/05/08 10:40:30, Michael Starzinger wrote:
> LGTM, with one suggestion.
> 
> https://codereview.chromium.org/14761010/diff/1/src/hydrogen-instructions.h
> File src/hydrogen-instructions.h (right):
> 
>
https://codereview.chromium.org/14761010/diff/1/src/hydrogen-instructions.h#n...
> src/hydrogen-instructions.h:2362: ElementsKind kind() const { return kind_; }
> There are so many "kind"s in V8 already, can we rename the field and the
> accessor to "elements_kind" here?

Powered by Google App Engine
This is Rietveld 408576698