src/ia32/lithium-codegen-ia32.cc - Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Renamed field Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 449ed3e917ee7a977858eb3c41e33a06eecb2426..a211ee8333f298c7bd6864f91d98cbd930414e98 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -4198,8 +4198,7 @@ void LCodeGen::DoCallNewArray(LCallNewArray* instr) {

__ Set(eax, Immediate(instr->arity()));

__ mov(ebx, instr->hydrogen()->property_cell());

- Object* cell_value = instr->hydrogen()->property_cell()->value();

- ElementsKind kind = static_cast<ElementsKind>(Smi::cast(cell_value)->value());

+ ElementsKind kind = instr->hydrogen()->elements_kind();

if (instr->arity() == 0) {

ArrayNoArgumentConstructorStub stub(kind);

CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »