Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renamed field Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3858 matching lines...) Expand 10 before | Expand all | Expand 10 after
3869 } 3869 }
3870 3870
3871 3871
3872 void LCodeGen::DoCallNewArray(LCallNewArray* instr) { 3872 void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
3873 ASSERT(ToRegister(instr->constructor()).is(rdi)); 3873 ASSERT(ToRegister(instr->constructor()).is(rdi));
3874 ASSERT(ToRegister(instr->result()).is(rax)); 3874 ASSERT(ToRegister(instr->result()).is(rax));
3875 ASSERT(FLAG_optimize_constructed_arrays); 3875 ASSERT(FLAG_optimize_constructed_arrays);
3876 3876
3877 __ Set(rax, instr->arity()); 3877 __ Set(rax, instr->arity());
3878 __ Move(rbx, instr->hydrogen()->property_cell()); 3878 __ Move(rbx, instr->hydrogen()->property_cell());
3879 Object* cell_value = instr->hydrogen()->property_cell()->value(); 3879 ElementsKind kind = instr->hydrogen()->elements_kind();
3880 ElementsKind kind = static_cast<ElementsKind>(Smi::cast(cell_value)->value());
3881 if (instr->arity() == 0) { 3880 if (instr->arity() == 0) {
3882 ArrayNoArgumentConstructorStub stub(kind); 3881 ArrayNoArgumentConstructorStub stub(kind);
3883 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 3882 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
3884 } else if (instr->arity() == 1) { 3883 } else if (instr->arity() == 1) {
3885 ArraySingleArgumentConstructorStub stub(kind); 3884 ArraySingleArgumentConstructorStub stub(kind);
3886 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 3885 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
3887 } else { 3886 } else {
3888 ArrayNArgumentsConstructorStub stub(kind); 3887 ArrayNArgumentsConstructorStub stub(kind);
3889 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 3888 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
3890 } 3889 }
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
5697 FixedArray::kHeaderSize - kPointerSize)); 5696 FixedArray::kHeaderSize - kPointerSize));
5698 __ bind(&done); 5697 __ bind(&done);
5699 } 5698 }
5700 5699
5701 5700
5702 #undef __ 5701 #undef __
5703 5702
5704 } } // namespace v8::internal 5703 } } // namespace v8::internal
5705 5704
5706 #endif // V8_TARGET_ARCH_X64 5705 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698