Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474293002: [debugger] Remove code to predict step-in target. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Remove code to predict step-in target. R=verwaest@chromium.org Committed: https://crrev.com/2f559f210d5a6fd60ab8471c0bd3f924a5a8f450 Cr-Commit-Position: refs/heads/master@{#32449}

Patch Set 1 #

Patch Set 2 : tentative fix #

Patch Set 3 : fix async stepping #

Patch Set 4 : prettify #

Patch Set 5 : fixed everything #

Patch Set 6 : finishing #

Patch Set 7 : fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -228 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M src/assembler.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/debug.h View 1 2 3 4 5 chunks +9 lines, -14 lines 0 comments Download
M src/debug/debug.cc View 1 2 3 4 5 11 chunks +40 lines, -146 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 4 4 chunks +3 lines, -24 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
Yang
5 years ago (2015-11-27 07:53:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474293002/1
5 years ago (2015-11-27 07:53:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 08:13:45 UTC) #5
Toon Verwaest
lgtm
5 years ago (2015-11-27 10:57:44 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474293002/60001
5 years ago (2015-11-30 09:14:30 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12454)
5 years ago (2015-11-30 09:26:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474293002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474293002/100001
5 years ago (2015-12-01 09:51:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/7403)
5 years ago (2015-12-01 09:54:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474293002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474293002/120001
5 years ago (2015-12-01 10:22:42 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-12-01 10:53:49 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-01 10:54:21 UTC) #21
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/2f559f210d5a6fd60ab8471c0bd3f924a5a8f450
Cr-Commit-Position: refs/heads/master@{#32449}

Powered by Google App Engine
This is Rietveld 408576698