Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 1474293002: [debugger] Remove code to predict step-in target. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix mips Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 1290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 } 1301 }
1302 bind(&regular_invoke); 1302 bind(&regular_invoke);
1303 } 1303 }
1304 } 1304 }
1305 1305
1306 1306
1307 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target, 1307 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target,
1308 const ParameterCount& expected, 1308 const ParameterCount& expected,
1309 const ParameterCount& actual) { 1309 const ParameterCount& actual) {
1310 Label skip_flooding; 1310 Label skip_flooding;
1311 ExternalReference debug_step_action = 1311 ExternalReference step_in_enabled =
1312 ExternalReference::debug_last_step_action_address(isolate()); 1312 ExternalReference::debug_step_in_enabled_address(isolate());
1313 mov(r4, Operand(debug_step_action)); 1313 mov(r4, Operand(step_in_enabled));
1314 ldrb(r4, MemOperand(r4)); 1314 ldrb(r4, MemOperand(r4));
1315 cmp(r4, Operand(StepIn)); 1315 cmp(r4, Operand(0));
1316 b(ne, &skip_flooding); 1316 b(eq, &skip_flooding);
1317 { 1317 {
1318 FrameScope frame(this, 1318 FrameScope frame(this,
1319 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL); 1319 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL);
1320 if (expected.is_reg()) { 1320 if (expected.is_reg()) {
1321 SmiTag(expected.reg()); 1321 SmiTag(expected.reg());
1322 Push(expected.reg()); 1322 Push(expected.reg());
1323 } 1323 }
1324 if (actual.is_reg()) { 1324 if (actual.is_reg()) {
1325 SmiTag(actual.reg()); 1325 SmiTag(actual.reg());
1326 Push(actual.reg()); 1326 Push(actual.reg());
(...skipping 2402 matching lines...) Expand 10 before | Expand all | Expand 10 after
3729 } 3729 }
3730 } 3730 }
3731 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift)); 3731 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift));
3732 add(result, result, Operand(dividend, LSR, 31)); 3732 add(result, result, Operand(dividend, LSR, 31));
3733 } 3733 }
3734 3734
3735 } // namespace internal 3735 } // namespace internal
3736 } // namespace v8 3736 } // namespace v8
3737 3737
3738 #endif // V8_TARGET_ARCH_ARM 3738 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698