Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: src/objects.cc

Issue 1474293002: [debugger] Remove code to predict step-in target. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix mips Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <iomanip> 8 #include <iomanip>
9 #include <sstream> 9 #include <sstream>
10 10
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
1055 // that location. The best solution seems to be to break the impasse by 1055 // that location. The best solution seems to be to break the impasse by
1056 // adding checks at possible recursion points. What's more, we don't put 1056 // adding checks at possible recursion points. What's more, we don't put
1057 // this stack check behind the USE_SIMULATOR define in order to keep 1057 // this stack check behind the USE_SIMULATOR define in order to keep
1058 // behavior the same between hardware and simulators. 1058 // behavior the same between hardware and simulators.
1059 StackLimitCheck check(isolate); 1059 StackLimitCheck check(isolate);
1060 if (check.JsHasOverflowed()) { 1060 if (check.JsHasOverflowed()) {
1061 isolate->StackOverflow(); 1061 isolate->StackOverflow();
1062 return MaybeHandle<Object>(); 1062 return MaybeHandle<Object>();
1063 } 1063 }
1064 1064
1065 Debug* debug = isolate->debug();
1066 // Handle stepping into a getter if step into is active.
1067 // TODO(rossberg): should this apply to getters that are function proxies?
1068 if (debug->is_active()) debug->HandleStepIn(getter);
1069
1070 return Execution::Call(isolate, getter, receiver, 0, NULL); 1065 return Execution::Call(isolate, getter, receiver, 0, NULL);
1071 } 1066 }
1072 1067
1073 1068
1074 Maybe<bool> Object::SetPropertyWithDefinedSetter(Handle<Object> receiver, 1069 Maybe<bool> Object::SetPropertyWithDefinedSetter(Handle<Object> receiver,
1075 Handle<JSReceiver> setter, 1070 Handle<JSReceiver> setter,
1076 Handle<Object> value, 1071 Handle<Object> value,
1077 ShouldThrow should_throw) { 1072 ShouldThrow should_throw) {
1078 Isolate* isolate = setter->GetIsolate(); 1073 Isolate* isolate = setter->GetIsolate();
1079 1074
1080 Debug* debug = isolate->debug();
1081 // Handle stepping into a setter if step into is active.
1082 // TODO(rossberg): should this apply to getters that are function proxies?
1083 if (debug->is_active()) debug->HandleStepIn(setter);
1084
1085 Handle<Object> argv[] = { value }; 1075 Handle<Object> argv[] = { value };
1086 RETURN_ON_EXCEPTION_VALUE(isolate, Execution::Call(isolate, setter, receiver, 1076 RETURN_ON_EXCEPTION_VALUE(isolate, Execution::Call(isolate, setter, receiver,
1087 arraysize(argv), argv), 1077 arraysize(argv), argv),
1088 Nothing<bool>()); 1078 Nothing<bool>());
1089 return Just(true); 1079 return Just(true);
1090 } 1080 }
1091 1081
1092 1082
1093 // static 1083 // static
1094 bool JSObject::AllCanRead(LookupIterator* it) { 1084 bool JSObject::AllCanRead(LookupIterator* it) {
(...skipping 17506 matching lines...) Expand 10 before | Expand all | Expand 10 after
18601 if (cell->value() != *new_value) { 18591 if (cell->value() != *new_value) {
18602 cell->set_value(*new_value); 18592 cell->set_value(*new_value);
18603 Isolate* isolate = cell->GetIsolate(); 18593 Isolate* isolate = cell->GetIsolate();
18604 cell->dependent_code()->DeoptimizeDependentCodeGroup( 18594 cell->dependent_code()->DeoptimizeDependentCodeGroup(
18605 isolate, DependentCode::kPropertyCellChangedGroup); 18595 isolate, DependentCode::kPropertyCellChangedGroup);
18606 } 18596 }
18607 } 18597 }
18608 18598
18609 } // namespace internal 18599 } // namespace internal
18610 } // namespace v8 18600 } // namespace v8
OLDNEW
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698