Clear SVG Web Animation effects when animations exit their fill phase

Clear SVG Web Animation effects when animations exit their fill phase

SVG Animations run via Web Animations were not clearing their effects
when the animation ceases to be in effect.
This change tracks the animated attributes on SVG elements and clears
them appropriately.

BUG=549009
Committed: https://crrev.com/aa9c2478459fc10444a8c6d3fbe0ed61f8885421
Cr-Commit-Position: refs/heads/master@{#362080}

[alancutter (OOO until 2018), 2015-11-27 06:50:59]

Description was changed from

==========
Clear SVG Web Animation effects when animations exit their fill phase

BUG=
==========

to

==========
Clear SVG Web Animation effects when animations exit their fill phase

SVG Animations run via Web Animations were not clearing their effects
when the animation ceases to be in effect.
This change tracks the animated attributes on SVG elements and clears
them appropriately.

BUG=549009
==========

[alancutter (OOO until 2018), 2015-11-27 06:50:59]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org, fs@opera.com

[fs, 2015-11-27 09:34:37]

LGTM w/ a few nit-level issues.

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElement.cpp:269: for (const QualifiedName*
attribute : ensureSVGRareData()->webAnimatedAttributes()) {
Use svgRareData (+assert/check) here (and below) instead?

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElementRareData.h (right):

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElementRareData.h:101:
WillBeHeapHashSet<const QualifiedName*> m_webAnimatedAttributes;
Why is this a HeapHashSet? QualifiedName* is not an Oilpan type? (ditto
QualifiedName)

[alancutter (OOO until 2018), 2015-11-30 00:24:11]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-11-30 00:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1474263002/#ps40001
(title: "Review changes")

[commit-bot: I haz the power, 2015-11-30 00:24:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474263002/40001

[alancutter (OOO until 2018), 2015-11-30 00:43:30]

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElement.cpp:269: for (const QualifiedName*
attribute : ensureSVGRareData()->webAnimatedAttributes()) {
On 2015/11/27 at 09:34:36, fs wrote:
> Use svgRareData (+assert/check) here (and below) instead?

Done.

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGElementRareData.h (right):

https://codereview.chromium.org/1474263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGElementRareData.h:101:
WillBeHeapHashSet<const QualifiedName*> m_webAnimatedAttributes;
On 2015/11/27 at 09:34:36, fs wrote:
> Why is this a HeapHashSet? QualifiedName* is not an Oilpan type? (ditto
QualifiedName)

Force of habit, thanks for catching. :)

[alancutter (OOO until 2018), 2015-11-30 01:15:55]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-11-30 01:15:56]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1474263002/#ps60001
(title: "Check rare data")

[commit-bot: I haz the power, 2015-11-30 01:16:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474263002/60001

[commit-bot: I haz the power, 2015-11-30 02:18:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-30 02:19:36]

Description was changed from

==========
Clear SVG Web Animation effects when animations exit their fill phase

SVG Animations run via Web Animations were not clearing their effects
when the animation ceases to be in effect.
This change tracks the animated attributes on SVG elements and clears
them appropriately.

BUG=549009
==========

to

==========
Clear SVG Web Animation effects when animations exit their fill phase

SVG Animations run via Web Animations were not clearing their effects
when the animation ceases to be in effect.
This change tracks the animated attributes on SVG elements and clears
them appropriately.

BUG=549009

Committed: https://crrev.com/aa9c2478459fc10444a8c6d3fbe0ed61f8885421
Cr-Commit-Position: refs/heads/master@{#362080}
==========

[commit-bot: I haz the power, 2015-11-30 02:19:36]

Patchset 4 (id:??) landed as
https://crrev.com/aa9c2478459fc10444a8c6d3fbe0ed61f8885421
Cr-Commit-Position: refs/heads/master@{#362080}