third_party/WebKit/Source/core/animation/KeyframeEffect.cpp - Issue 1474263002: Clear SVG Web Animation effects when animations exit their fill phase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

Issue 1474263002: Clear SVG Web Animation effects when animations exit their fill phase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgPathInterpolationType

Patch Set: Check rare data Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/clear-svg-animation-effects.html ('k') | third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

index 1ac4bf6dd61860701f648a5cc0d28be298cda05e..50d453fe2ccff06f411e8455d12fe5ac7fe8b458 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

@@ -209,6 +209,8 @@ void KeyframeEffect::clearEffects()

m_sampledEffect = nullptr;

restartAnimationOnCompositor();

m_target->setNeedsAnimationStyleRecalc();

+ if (RuntimeEnabledFeatures::webAnimationsSVGEnabled() && m_target->isSVGElement())

+ toSVGElement(*m_target).clearWebAnimatedAttributes();

invalidate();

}