Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1474003002: Re-enable OnNavStateChanged test. (Closed)

Created:
5 years ago by Charlie Reis
Modified:
5 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable OnNavStateChanged test. This test apparently was failing earlier (no mention of flakiness) but passes now. Re-enabling to make sure we have coverage. BUG=157213 TEST=Test passes on bots. Committed: https://crrev.com/5fcf7659211ea58d973261d61837008566ee3562 Cr-Commit-Position: refs/heads/master@{#361759}

Patch Set 1 #

Patch Set 2 : Skip in OOPIF modes for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/renderer/render_view_browsertest.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Charlie Reis
I'm hoping to re-enable this before https://codereview.chromium.org/1449353002/. Looks like it's passing for me locally, and ...
5 years ago (2015-11-25 20:22:02 UTC) #2
Avi (use Gerrit)
lgtm
5 years ago (2015-11-25 20:32:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474003002/20001
5 years ago (2015-11-25 20:34:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-25 22:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474003002/20001
5 years ago (2015-11-25 22:16:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 00:30:58 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 00:32:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fcf7659211ea58d973261d61837008566ee3562
Cr-Commit-Position: refs/heads/master@{#361759}

Powered by Google App Engine
This is Rietveld 408576698