Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1474003002: Re-enable OnNavStateChanged test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Skip in OOPIF modes for now Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 724c8e853eeab87ee86275086c6c7fa19b604a59..ca24f5ad300340271daf206809c561915fa5d283 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -452,7 +452,12 @@ TEST_F(RenderViewImplTest, SaveImageFromDataURL) {
}
// Test that we get form state change notifications when input fields change.
-TEST_F(RenderViewImplTest, DISABLED_OnNavStateChanged) {
+TEST_F(RenderViewImplTest, OnNavStateChanged) {
+ // TODO(creis): Make the UpdateState timer work in OOPIF modes.
+ // See https://crbug.com/545219.
+ if (SiteIsolationPolicy::UseSubframeNavigationEntries())
+ return;
+
// Don't want any delay for form state sync changes. This will still post a
// message so updates will get coalesced, but as soon as we spin the message
// loop, it will generate an update.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698