chrome/browser/ui/zoom/zoom_controller_browsertest.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/signin/inline_login_handler.cc ('K') | « chrome/browser/ui/webui/webui_webview_browsertest.cc ('k') | chrome/test/base/test_browser_window.h » ('j') | components/signin/core/browser/signin_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

diff --git a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

index d8bcbddfabd687c2b0024ad45199c81e0b2fdd7d..68c43c40f549c196c11a572d04d0cfcc9ebe7846 100644

--- a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

+++ b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

@@ -276,8 +276,8 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, NavigationResetsManualMode) {

// Regression test: crbug.com/438979.

IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,

SettingsZoomAfterSigninWorks) {

- GURL signin_url(

- std::string(chrome::kChromeUIChromeSigninURL).append("?source=0"));

+ GURL signin_url(std::string(chrome::kChromeUIChromeSigninURL)

+ .append("?access_point=0&reason=0"));

// We open the signin page in a new tab so that the ZoomController is

// created against the HostZoomMap of the special StoragePartition that

// backs the signin page. When we subsequently navigate away from the