Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4772)

Unified Diff: chrome/test/base/test_browser_window.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/test_browser_window.h
diff --git a/chrome/test/base/test_browser_window.h b/chrome/test/base/test_browser_window.h
index ebe738694d7931d54e800470a1413578a3a8d678..a67dcc82378aa6798bf9048b370e625f186a7001 100644
--- a/chrome/test/base/test_browser_window.h
+++ b/chrome/test/base/test_browser_window.h
@@ -147,8 +147,11 @@ class TestBrowserWindow : public BrowserWindow {
override;
void ShowAvatarBubbleFromAvatarButton(
AvatarBubbleMode mode,
- const signin::ManageAccountsParams& manage_accounts_params) override {}
- void ShowModalSigninWindow(AvatarBubbleMode mode) override {}
+ const signin::ManageAccountsParams& manage_accounts_params,
+ signin_metrics::AccessPoint access_point) override {}
+ void ShowModalSigninWindow(
+ AvatarBubbleMode mode,
+ signin_metrics::AccessPoint access_point) override {}
void CloseModalSigninWindow() override {}
int GetRenderViewHeightInsetWithDetachedBookmarkBar() override;
void ExecuteExtensionCommand(const extensions::Extension* extension,

Powered by Google App Engine
This is Rietveld 408576698