chrome/browser/ui/webui/webui_webview_browsertest.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/webui_webview_browsertest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/signin/inline_login_handler.cc ('K') | « chrome/browser/ui/webui/sync_setup_browsertest.js ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | components/signin/core/browser/signin_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/webui_webview_browsertest.cc

diff --git a/chrome/browser/ui/webui/webui_webview_browsertest.cc b/chrome/browser/ui/webui/webui_webview_browsertest.cc

index 2ed4fa8a6613c09402c46f7d4a91a4659ddc8a92..2db0cb7a1d2fcb14927655efc3d376de7de8aa9e 100644

--- a/chrome/browser/ui/webui/webui_webview_browsertest.cc

+++ b/chrome/browser/ui/webui/webui_webview_browsertest.cc

@@ -6,6 +6,7 @@

#include "base/path_service.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"

+#include "chrome/browser/signin/signin_promo.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_paths.h"

@@ -37,7 +38,9 @@ class WebUIWebViewBrowserTest : public WebUIBrowserTest {

}

GURL GetWebViewEnabledWebUIURL() const {

- return GURL(chrome::kChromeUIChromeSigninURL);

+ return GURL(signin::GetPromoURL(

+ signin_metrics::ACCESS_POINT_START_PAGE,

+ signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT, false));

}

private: