chrome/browser/ui/webui/sync_setup_browsertest.js - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_browsertest.js

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/signin/inline_login_handler.cc ('K') | « chrome/browser/ui/webui/signin/login_ui_test_utils.cc ('k') | chrome/browser/ui/webui/webui_webview_browsertest.cc » ('j') | components/signin/core/browser/signin_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_setup_browsertest.js

diff --git a/chrome/browser/ui/webui/sync_setup_browsertest.js b/chrome/browser/ui/webui/sync_setup_browsertest.js

index e65c4026e26595716324876aa4242f40b592fdde..98f08d12844bb4b8ed70ae451c7693a3427ec205 100644

--- a/chrome/browser/ui/webui/sync_setup_browsertest.js

+++ b/chrome/browser/ui/webui/sync_setup_browsertest.js

@@ -85,7 +85,7 @@ TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {

// Handle SyncSetupStartSignIn by displaying the sync setup dialog, verifying

// that a confirmation dialog appears, and clicking OK to dismiss the dialog.

// Note that this test doesn't actually do a gaia sign in.

- this.mockHandler.expects(once()).SyncSetupStartSignIn().will(callFunction(

+ this.mockHandler.expects(once()).SyncSetupStartSignIn('access-point-settings').will(callFunction(

function() {

SyncSetupOverlay.showSyncSetupPage('configure');

var okButton = $('confirm-everything-ok');

@@ -103,7 +103,7 @@ TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {

// Test that switching to and from "Sync everything" saves and restores types.

TEST_F('SyncSetupWebUITestAsync', 'RestoreSyncDataTypes', function() {

- this.mockHandler.expects(once()).SyncSetupStartSignIn().will(callFunction(

+ this.mockHandler.expects(once()).SyncSetupStartSignIn('access-point-settings').will(callFunction(

function() {

SyncSetupOverlay.showSyncSetupPage('configure', {});