Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4208)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 08d9722429b99133460ec0864c87c0a2a0d22770..a3785921768ddcec40ce6a28437ea1fe7018a2a3 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2552,7 +2552,8 @@ void BrowserView::UpdateAcceleratorMetrics(const ui::Accelerator& accelerator,
void BrowserView::ShowAvatarBubbleFromAvatarButton(
AvatarBubbleMode mode,
- const signin::ManageAccountsParams& manage_accounts_params) {
+ const signin::ManageAccountsParams& manage_accounts_params,
+ signin_metrics::AccessPoint access_point) {
#if defined(FRAME_AVATAR_BUTTON)
// Do not show avatar bubble if there is no avatar menu button.
if (!frame_->GetNewAvatarMenuButton())
@@ -2564,10 +2565,10 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(
&tutorial_mode);
if (SigninViewController::ShouldShowModalSigninForMode(bubble_view_mode)) {
- ShowModalSigninWindow(mode);
+ ShowModalSigninWindow(mode, access_point);
} else {
ProfileChooserView::ShowBubble(
- bubble_view_mode, tutorial_mode, manage_accounts_params,
+ bubble_view_mode, tutorial_mode, manage_accounts_params, access_point,
frame_->GetNewAvatarMenuButton(), views::BubbleBorder::TOP_RIGHT,
views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE, browser());
ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ICON_AVATAR_BUBBLE);
@@ -2577,12 +2578,15 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(
#endif
}
-void BrowserView::ShowModalSigninWindow(AvatarBubbleMode mode) {
+void BrowserView::ShowModalSigninWindow(
+ AvatarBubbleMode mode,
+ signin_metrics::AccessPoint access_point) {
profiles::BubbleViewMode bubble_view_mode;
profiles::TutorialMode tutorial_mode;
profiles::BubbleViewModeFromAvatarBubbleMode(mode, &bubble_view_mode,
&tutorial_mode);
- signin_view_controller_.ShowModalSignin(bubble_view_mode, browser());
+ signin_view_controller_.ShowModalSignin(bubble_view_mode, browser(),
+ access_point);
}
void BrowserView::CloseModalSigninWindow() {

Powered by Google App Engine
This is Rietveld 408576698