chrome/browser/signin/signin_global_error.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/principals_private/principals_private_api.cc ('K') | « chrome/browser/signin/chrome_signin_helper.cc ('k') | chrome/browser/signin/signin_promo.h » ('j') | chrome/browser/ui/browser_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index 71f8a46ac91fe04eaa833dc752a4747930ce4d66..32674edadc35ce9d2eead669c888b831ba6fd011 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -98,8 +98,8 @@ void SigninGlobalError::ExecuteMenuItem(Browser* browser) {

signin_metrics::HISTOGRAM_REAUTH_SHOWN,

signin_metrics::HISTOGRAM_REAUTH_MAX);

browser->window()->ShowAvatarBubbleFromAvatarButton(

- BrowserWindow::AVATAR_BUBBLE_MODE_REAUTH,

- signin::ManageAccountsParams());

+ BrowserWindow::AVATAR_BUBBLE_MODE_REAUTH, signin::ManageAccountsParams(),

+ signin_metrics::ACCESS_POINT_SETTINGS);

Roger Tawa OOO till Jul 10th 2015/12/02 20:33:48 I don't think this is the right access point. How

gogerald1 2015/12/03 17:49:03 Done.

#endif

}