chrome/browser/ui/browser_commands.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_global_error.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_mac.h » ('j') | chrome/browser/ui/webui/app_launcher_login_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 0af8c4808045740467908583b51e0ab7f5a255d4..2f7b2cda2c3a6fe65f73f6d704b1f7b1d3b4b13c 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -1103,14 +1103,15 @@ void ShowAppMenu(Browser* browser) {

void ShowAvatarMenu(Browser* browser) {

Roger Tawa OOO till Jul 10th 2015/12/02 20:33:48 This function should take an access point argument

gogerald1 2015/12/03 17:49:03 Use signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIG

browser->window()->ShowAvatarBubbleFromAvatarButton(

- BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT,

- signin::ManageAccountsParams());

+ BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT, signin::ManageAccountsParams(),

+ signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

}

void ShowFastUserSwitcher(Browser* browser) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,

- signin::ManageAccountsParams());

+ signin::ManageAccountsParams(),

+ signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

Roger Tawa OOO till Jul 10th 2015/12/02 20:33:48 This seems to be called only from the menu? https

gogerald1 2015/12/03 17:49:03 Use signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIG

}

void OpenUpdateChromeDialog(Browser* browser) {