chrome/browser/extensions/api/principals_private/principals_private_api.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/principals_private/principals_private_api.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/principals_private/principals_private_api.cc

diff --git a/chrome/browser/extensions/api/principals_private/principals_private_api.cc b/chrome/browser/extensions/api/principals_private/principals_private_api.cc

index 491f4195f06ebf5f6156416dd4163224be91179c..650fe3cd0d560f6835a00125c4689e05ad3dce77 100644

--- a/chrome/browser/extensions/api/principals_private/principals_private_api.cc

+++ b/chrome/browser/extensions/api/principals_private/principals_private_api.cc

@@ -36,7 +36,8 @@ bool PrincipalsPrivateShowAvatarBubbleFunction::RunSyncSafe() {

if (browser) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,

- signin::ManageAccountsParams());

+ signin::ManageAccountsParams(),

+ signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

Roger Tawa OOO till Jul 10th 2015/12/02 20:33:48 This does not seem like the right access point.

gogerald1 2015/12/03 17:49:03 Use signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIG

}

return true;

}

« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | chrome/browser/signin/signin_global_error.cc » ('J')