Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1476923005: Only build against prebuilt sysroot when using clang (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only build against prebuilt sysroot when using clang Its is not currently possible to use gcc with the sysroot since the sysroot only contains C++ headers for gcc 4.6 and gcc 4.8 is required to build chromium. Luckily clang is more flexible and able to detect and work with the 4.6 headers in the sysroot. BUG=504446 Committed: https://crrev.com/ccc8c1e14c155255a8ef844704d97fa8e7d0dac2 Cr-Commit-Position: refs/heads/master@{#361905}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M build/common.gypi View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M build/config/sysroot.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Sam Clegg
5 years ago (2015-11-25 19:46:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476923005/20001
5 years ago (2015-11-25 20:29:07 UTC) #4
Dirk Pranke
lgtm
5 years ago (2015-11-25 20:32:39 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/122347) linux_chromium_clobber_rel_ng on ...
5 years ago (2015-11-25 20:38:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476923005/40001
5 years ago (2015-11-25 21:40:52 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-25 23:47:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476923005/40001
5 years ago (2015-11-26 16:36:50 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 16:41:21 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ccc8c1e14c155255a8ef844704d97fa8e7d0dac2 Cr-Commit-Position: refs/heads/master@{#361905}
5 years ago (2015-11-26 16:42:38 UTC) #17
brucedawson
5 years ago (2015-11-26 19:26:03 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1483433002/ by brucedawson@chromium.org.

The reason for reverting is: Speculative revert to fix:

FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
ia32 -d google_chrome -c beta
dpkg-shlibdeps: warning: binaries to analyze should already be installed in
their package's directory.
4c4
< libc6 (>= 2.11)
---
> libc6 (>= 2.15)

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux....

Powered by Google App Engine
This is Rietveld 408576698